Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): add component for multi column layout #1316

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gabriele-ct
Copy link
Contributor

fixes: #1260

@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2022

⚠️ No Changeset found

Latest commit: 9565045

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

Deploy preview for commercetools-docs-kit ready!

✅ Preview
https://commercetools-docs-qo1y0npmj-commercetools.vercel.app
https://docskit-sha-0306d37f39254f70ae9b1dcc7078fe5ba5aaeae7.commercetools.vercel.app
https://docskit-pr-1316.commercetools.vercel.app

Built with commit 9565045.
This pull request is being automatically deployed with vercel-action

@gabriele-ct gabriele-ct added the 👨‍🎨 Status: UX Review Requires review from design team label Jun 7, 2022
@gabriele-ct
Copy link
Contributor Author

I've created a POC simple multi column component. I think the next step is to gather feedback from UX.
The component is visible here: https://docskit-pr-1316.commercetools.vercel.app/docs-smoke-test/components/multi-column-layout

@gabriele-ct gabriele-ct force-pushed the ga-multi-column-layout branch from 6f8b845 to d625a26 Compare June 16, 2022 08:25
…mercetools-docs-kit into ga-multi-column-layout
@gabriele-ct
Copy link
Contributor Author

@nkuehn thanks for your feedback.
I've updated the PR according to your comment
#1260 (comment)
Not sure about the next steps. Shall I assign it to someone specific for UX review or just go ahead adding changeset and make it a "proper" PR ?

@gabriele-ct
Copy link
Contributor Author

gabriele-ct commented Jun 16, 2022

Hey @stmeissner. I've done some work about this issue and there's been some directions from @nkuehn regarding how many columns we should divide the content into.
As we don't have UX available at the moment, would you mind you and the team having a look to https://docskit-pr-1316.commercetools.vercel.app/docs-smoke-test/components/multi-column-layout and tell me if it's what you guys were expecting?
Thank you 👍

@timonrey timonrey added 🖐 Status: On Hold and removed 👨‍🎨 Status: UX Review Requires review from design team labels Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide component for multi-column layout
2 participants