Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create utility components for self-learning purpose #2107

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

gabriele-ct
Copy link
Contributor

@gabriele-ct gabriele-ct commented Jan 23, 2025

Description of changes

we introduce 2 new components to get rid of custom markup used in the self-learning pages which leads to hydration issues and semantic problems. This work is also useful for next docs as it allows to remove icons dependencies from the mdx

Screenshot of changes (if applicable)
SelfLearningContentNotification component
Screenshot 2025-01-23 at 19 06 06

LearningObjectivesCard component
Screenshot 2025-01-23 at 19 07 35

DoD guidelines

  • user documentation added?
  • stakeholders approve changes? (if needed)

Copy link

changeset-bot bot commented Jan 23, 2025

🦋 Changeset detected

Latest commit: 3a10a00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@commercetools-website/self-learning-smoke-test Minor
@commercetools-docs/gatsby-theme-docs Minor
@commercetools-website/docs-smoke-test Minor
@commercetools-website/api-docs-smoke-test Patch
@commercetools-website/documentation Patch
@commercetools-website/site-template Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gabriele-ct gabriele-ct requested a review from a team January 23, 2025 18:05
Copy link
Contributor

github-actions bot commented Jan 23, 2025

Copy link
Contributor

@FFawzy FFawzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🚀

@gabriele-ct gabriele-ct merged commit 319ebed into main Jan 23, 2025
10 checks passed
@gabriele-ct gabriele-ct deleted the ga-icon-components branch January 23, 2025 21:20
@ct-changesets ct-changesets bot mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants