-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate abstract syncer #484
Migrate abstract syncer #484
Conversation
ResourceDraftT, | ||
SyncStatisticsT extends BaseSyncStatistics, | ||
SyncOptionsT extends BaseSyncOptions<ResourceT, ResourceDraftT, ResourceUpdateActionT>, | ||
PagedQueryT extends PagedQueryResourceRequest<PagedQueryT, PagedQueryResponseT>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use non-deprecated version of PagedQueryResourceRequest
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've already tried to use the non-deprecated but it's conflicting with the QueryAll utils in sdk. I will create a ticket to have a look at this later.
@Nonnull | ||
CompletionStage<CustomObject<LastSyncCustomObject>> createLastSyncCustomObject( | ||
CompletableFuture<ApiHttpResponse<CustomObject>> createLastSyncCustomObject( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's more consistent when all the methods returns either CompletableFuture or CompletionStage.
* Install sync-java-version 10 beta and change http client. * Migrate abstract syncer (#484) * Migrate abstract syncer, utils and tests (only compilable) * Adjust javadoc * Use consistent return type * Make syncer implementation compilable (#485) * Migrate abstract syncer, utils and tests (only compilable) * Adjust javadoc * Adjust signature of syncer subclasses and fix code * Formatting * Remove unused constant * Comment not compilable unittests * Migrate SyncerFactory and CliRunner (#496) * Migrate SyncerFactory * Migrate client utils and rename * Migrate CliRunner * Migrate unittests for SyncerFactory * Migrate unittests for CLIRunner * Cleanup test code * Add final modifier Co-authored-by: Lam Tran <[email protected]> --------- Co-authored-by: Lam Tran <[email protected]> * Approved tasks from syncer factory base (#497) * Migrate SyncerFactory * Migrate client utils and rename * Migrate CliRunner * Migrate unittests for SyncerFactory * Migrate unittests for CLIRunner * Cleanup test code * DEVX-259 fix tests (#494) * DEVX-246 migrate solution info (#491) --------- Co-authored-by: Lam Tran <[email protected]> * Fix spotbugs violations * DEVX-247 migrate category syncer (#498) * Revert "Fix spotbugs violations" This reverts commit 31da628. * Delete unused variable * DEVX-248 migrate inventory sync (#499) * Migrate SyncerFactory * Migrate client utils and rename * Migrate CliRunner * Migrate unittests for SyncerFactory * Migrate unittests for CLIRunner * Cleanup test code * DEVX-247 migrate category syncr * DEVX-247 fix spotbugs * DEVX-247 rename variable * DEVX-247 rename variable * DEVX-248 migrate inventory syncer * DEVX-248 refactor category syncer test * DEVX-248 refactor code * DEVX-248 fix formatting --------- Co-authored-by: salander85 <[email protected]> * Migrate product syncer with unittests (#502) * Migrate ITs for product syncer (#505) * DEVX-250 migrate cart discount syncer (#504) * DEVX-251 migrate customer syncer (#506) * DEVX-253 migrate product type syncer (#509) * Migrate shoppinglist syncer (#511) * DEVX-252 migrate custom object syncer (#503) * DEVX-252 migrate custom object syncer * DEVX-252 disable test * DEVX-245 fix category syncer IT (#514) * DEVX-245 fix category syncer IT * DEVX-245 fix formatting * Update sync-java to newest version * Revert "Update sync-java to newest version" This reverts commit a278421. * Migrate state-syncer incl. unittests (#512) * Migrate state-syncer incl. unittests * Make error-handling in transform consistent with other syncers * Assert instance of method call * Fix test * Migrate tax category syncer (#513) * Migrate type syncer (#515) * Migrate type syncer * Test type-sync fails with error callback * Replace private method with utility method. Correct tests. * Update sync-java to newest version (#517) * Update sync-java to newest version * Update http-client to newest version * DEVX-276 add retry (#516) * DEVX-276 add retry * DEVX-276 update retry mechanism * DEVX-276 fix tests * Migrate CLI runner IT (#508) * Update README.md --------- Co-authored-by: Lam Tran <[email protected]>
Migrate source class
Syncer
and some helper classes.Classes (and unit tests) do compile but aren't tested yet.
This PR is needed to create a base for the independent work on migration.
The following task isn't resolved by this PR:
JIRA: https://commercetools.atlassian.net/browse/DEVX-242