DEVX-245 fix category syncer IT #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## sync-java-migration-v10 #514 +/- ##
==========================================================
Coverage ? 91.40%
Complexity ? 237
==========================================================
Files ? 24
Lines ? 861
Branches ? 39
==========================================================
Hits ? 787
Misses ? 55
Partials ? 19 ☔ View full report in Codecov by Sentry. |
lojzatran
added a commit
that referenced
this pull request
Nov 6, 2023
* Install sync-java-version 10 beta and change http client. * Migrate abstract syncer (#484) * Migrate abstract syncer, utils and tests (only compilable) * Adjust javadoc * Use consistent return type * Make syncer implementation compilable (#485) * Migrate abstract syncer, utils and tests (only compilable) * Adjust javadoc * Adjust signature of syncer subclasses and fix code * Formatting * Remove unused constant * Comment not compilable unittests * Migrate SyncerFactory and CliRunner (#496) * Migrate SyncerFactory * Migrate client utils and rename * Migrate CliRunner * Migrate unittests for SyncerFactory * Migrate unittests for CLIRunner * Cleanup test code * Add final modifier Co-authored-by: Lam Tran <[email protected]> --------- Co-authored-by: Lam Tran <[email protected]> * Approved tasks from syncer factory base (#497) * Migrate SyncerFactory * Migrate client utils and rename * Migrate CliRunner * Migrate unittests for SyncerFactory * Migrate unittests for CLIRunner * Cleanup test code * DEVX-259 fix tests (#494) * DEVX-246 migrate solution info (#491) --------- Co-authored-by: Lam Tran <[email protected]> * Fix spotbugs violations * DEVX-247 migrate category syncer (#498) * Revert "Fix spotbugs violations" This reverts commit 31da628. * Delete unused variable * DEVX-248 migrate inventory sync (#499) * Migrate SyncerFactory * Migrate client utils and rename * Migrate CliRunner * Migrate unittests for SyncerFactory * Migrate unittests for CLIRunner * Cleanup test code * DEVX-247 migrate category syncr * DEVX-247 fix spotbugs * DEVX-247 rename variable * DEVX-247 rename variable * DEVX-248 migrate inventory syncer * DEVX-248 refactor category syncer test * DEVX-248 refactor code * DEVX-248 fix formatting --------- Co-authored-by: salander85 <[email protected]> * Migrate product syncer with unittests (#502) * Migrate ITs for product syncer (#505) * DEVX-250 migrate cart discount syncer (#504) * DEVX-251 migrate customer syncer (#506) * DEVX-253 migrate product type syncer (#509) * Migrate shoppinglist syncer (#511) * DEVX-252 migrate custom object syncer (#503) * DEVX-252 migrate custom object syncer * DEVX-252 disable test * DEVX-245 fix category syncer IT (#514) * DEVX-245 fix category syncer IT * DEVX-245 fix formatting * Update sync-java to newest version * Revert "Update sync-java to newest version" This reverts commit a278421. * Migrate state-syncer incl. unittests (#512) * Migrate state-syncer incl. unittests * Make error-handling in transform consistent with other syncers * Assert instance of method call * Fix test * Migrate tax category syncer (#513) * Migrate type syncer (#515) * Migrate type syncer * Test type-sync fails with error callback * Replace private method with utility method. Correct tests. * Update sync-java to newest version (#517) * Update sync-java to newest version * Update http-client to newest version * DEVX-276 add retry (#516) * DEVX-276 add retry * DEVX-276 update retry mechanism * DEVX-276 fix tests * Migrate CLI runner IT (#508) * Update README.md --------- Co-authored-by: Lam Tran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://commercetools.atlassian.net/browse/DEVX-245
When last sync timestamp cannot be found, an exception is being thrown in SDK v2. In the SDK v1, there was empty optional returned. Therefore I had to simulate the same behaviour. However, I need to catch other exceptions and rethrow. For this I had to wrap in RuntimeException and rethrow as there was no easy way just to rethrow the exception as is.
Because of the additional wrapping into
RuntimeExceptionI had to modify some tests as well.