Fixes/presales #91
Open
Fixes/presales #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f type "CustomerCreated"
…ow the template to be reused more often without adaptions
phofmann
requested review from
prateek-ct,
diegodeleonfagundez and
ruidias-commercetools
as code owners
|
ruidias-commercetools
approved these changes
Nov 4, 2024
diegodeleonfagundez
approved these changes
Nov 4, 2024
… creation, therefore making it more anonymous from a naming perspective
dario-commercetools
approved these changes
Nov 8, 2024
ruidias-commercetools
added
question
|
Please do not merge yet. Thanks 🙏🏻 |
|
@ruidias-commercetools is there anything I can do to move this PR forward? |
|
Hey @phofmann . We have @dario-commercetools working on this. Expect news from him on Monday. Thanks for the wait. |
|
Cool, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and context
We are using the template in presales a lot to show how easy it is to build events using connect. What we need to do so is a rapid development roundtrip. We achieve this by writing tests using them to e.g. trigger a customer created message.
Type of change
Brief description of the solution
IDEs like idea allow you to run tests right from within the IDE, taking away the pain of doing things e.g. via postman. On top the message payload is also versioned within git. On top, a lot of clients will use the template to build other subscriptions than customerCreated, so I renamed the code references.