-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add CustomViewInstallation
model
#422
Conversation
🦋 Changeset detectedLatest commit: b9c6ab9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CustomViewInstallation
modelcustom-view-installation
package
} from './types'; | ||
|
||
const transformers = { | ||
graphql: Transformer< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the default
transformer is mandatory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take a better look at this tomorrow
.changeset/blue-mangos-speak.md
Outdated
--- | ||
'@commercetools-test-data/custom-view': minor | ||
'@commercetools-test-data/custom-view-installation': minor | ||
--- | ||
|
||
New package to generate test data for Custom Views Installations. | ||
|
||
```ts | ||
import { | ||
RestrictedCustomViewInstallationForOrganization, | ||
type TRestrictedCustomViewInstallationForOrganizationGraphql, | ||
} from '@commercetools-test-data/custom-view-installation'; | ||
|
||
const restrictedCustomViewInstallationForOrganization = | ||
RestrictedCustomViewInstallationForOrganization.random().buildGraphql<TRestrictedCustomViewInstallationForOrganizationGraphql>(); | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can keep one package @commercetools-test-data/custom-view
and include the installation models in that as well.
38b14c1
to
093c79b
Compare
custom-view-installation
packageCustomViewInstallation
model
8384af8
to
f3b94c9
Compare
0a71416
to
e8ed40b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Kacper 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🤗
This PR updates the
custom-view
packageRestrictedCustomViewInstallationForOrganization
model specifically tailored for modelling theinstalledCustomViews
component within theOrganizationExtension
queryCustomViewInstallation
model