Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CustomViewInstallation model #422

Merged
merged 7 commits into from
Dec 5, 2023
Merged

Conversation

kark
Copy link
Contributor

@kark kark commented Oct 31, 2023

This PR updates the custom-view package

  • adds RestrictedCustomViewInstallationForOrganization model specifically tailored for modelling the installedCustomViews component within the OrganizationExtension query
  • adds CustomViewInstallation model

Copy link

changeset-bot bot commented Oct 31, 2023

🦋 Changeset detected

Latest commit: b9c6ab9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@commercetools-test-data/custom-view Minor
@commercetools-test-data/core Minor
@commercetools-test-data/graphql-types Minor
@commercetools-test-data/associate-role Minor
@commercetools-test-data/business-unit Minor
@commercetools-test-data/cart-discount Minor
@commercetools-test-data/cart Minor
@commercetools-test-data/category Minor
@commercetools-test-data/channel Minor
@commercetools-test-data/commons Minor
@commercetools-test-data/customer-group Minor
@commercetools-test-data/customer Minor
@commercetools-test-data/discount-code Minor
@commercetools-test-data/inventory-entry Minor
@commercetools-test-data/order Minor
@commercetools-test-data/payment Minor
@commercetools-test-data/product-discount Minor
@commercetools-test-data/product-selection Minor
@commercetools-test-data/product-type Minor
@commercetools-test-data/product Minor
@commercetools-test-data/quote-request Minor
@commercetools-test-data/quote Minor
@commercetools-test-data/review Minor
@commercetools-test-data/shipping-method Minor
@commercetools-test-data/shopping-list Minor
@commercetools-test-data/staged-quote Minor
@commercetools-test-data/store Minor
@commercetools-test-data/tax-category Minor
@commercetools-test-data/zone Minor
@commercetools-test-data/utils Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kark kark changed the title feat: add CustomViewInstallation model feat: add custom-view-installation package Oct 31, 2023
@kark kark requested a review from CarlosCortizasCT October 31, 2023 15:42
} from './types';

const transformers = {
graphql: Transformer<
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the default transformer is mandatory.

@kark kark requested a review from emmenko November 6, 2023 11:02
Copy link
Member

@emmenko emmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a better look at this tomorrow

Comment on lines 1 to 20
---
'@commercetools-test-data/custom-view': minor
'@commercetools-test-data/custom-view-installation': minor
---

New package to generate test data for Custom Views Installations.

```ts
import {
RestrictedCustomViewInstallationForOrganization,
type TRestrictedCustomViewInstallationForOrganizationGraphql,
} from '@commercetools-test-data/custom-view-installation';

const restrictedCustomViewInstallationForOrganization =
RestrictedCustomViewInstallationForOrganization.random().buildGraphql<TRestrictedCustomViewInstallationForOrganizationGraphql>();
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep one package @commercetools-test-data/custom-view and include the installation models in that as well.

@kark kark marked this pull request as draft November 13, 2023 08:21
@kark kark force-pushed the kk-custom-view-installation branch from 38b14c1 to 093c79b Compare November 20, 2023 11:19
models/custom-view/src/index.ts Outdated Show resolved Hide resolved
pnpm-lock.yaml Outdated Show resolved Hide resolved
@kark kark marked this pull request as ready for review November 20, 2023 11:39
@kark kark changed the title feat: add custom-view-installation package feat: add CustomViewInstallation model Nov 21, 2023
@kark kark force-pushed the kk-custom-view-installation branch from 8384af8 to f3b94c9 Compare November 21, 2023 07:39
@kark kark force-pushed the kk-custom-view-installation branch from 0a71416 to e8ed40b Compare December 1, 2023 13:42
Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kacper 👏

Copy link
Member

@emmenko emmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🤗

@kark kark merged commit 555c8da into main Dec 5, 2023
3 checks passed
@kark kark deleted the kk-custom-view-installation branch December 5, 2023 11:59
@ct-changesets ct-changesets bot mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants