PANGOLIN-3193 - New package for model: Type
#453
Conversation
🦋 Changeset detectedLatest commit: 050c814 The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…omFieldLocalizedStringtype models
…tomFieldDateTimeType
valoriecarli
force-pushed
the
PANGOLIN-3193-type-model
branch
from
dacd127 to
c7012fb
Compare
…omFieldLocalizedStringtype models
…tomFieldDateTimeType
valoriecarli
force-pushed
the
PANGOLIN-3193-type-model
branch
from
59f6864 to
c015cc2
Compare
|
|
||
| const transformers = { | ||
| default: Transformer<TTypeDraft, TTypeDraft>('default', { | ||
| buildFields: ['name', 'description'], |
| default: Transformer<TTypeDraft, TTypeDraft>('default', { | ||
| buildFields: ['name', 'description'], | ||
| }), | ||
| rest: Transformer<TTypeDraft, TTypeDraft>('rest', { |
| }), | ||
| // Note that the TypeDraft graphql is provided as scaffolding only and may not be complete at this time. | ||
| graphql: Transformer<TTypeDraft, TTypeDraftGraphql>('graphql', { | ||
| buildFields: ['name', 'description'], |
There was a problem hiding this comment.
@jmcreasman boop
Please add fieldDefinitions to the build fields here, as well as for the final/parent.
TL;DR - If a generator references another model, it will need to be added here... or you will be disappointed later when looking for results. Please see the slack thread regarding this.
Your test passes, but if you force it to fail and look into it, you'll see the issue. This will in turn provide a shape that will error out when called.
There was a problem hiding this comment.
I will go ahead and approve, but please don't forget to update both transformers as requested before merging.
Really appreciate you taking this one on. I know it was....a bit much. A lot of the grunt work is now complete, and others can come back in for minor tweaks. 💯
This PR consists of:
Type/TypeDraftFieldDefinitionmodel needed to supportTypeCustomFieldTypemodels needed to supportFieldDefinitionState(removing unused imports)Please note there is a LOT of scaffolding (particularly around graphQL related types) so that when/if those are needed the setup is there but this PR/ticket is focussed around what's needed for the e2e tests in AuditLog.
Happy to answer any questions