Skip to content

Restore dhall and reverse dependencies #3361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2018

Conversation

Gabriella439
Copy link
Contributor

The latest version of dhall builds against the latest version of ansi-terminal

Checklist:

  • Meaningful commit message - please not Update build-constraints.yml

  • Some time passed since Hackage upload

  • On your own machine, in a new directory, you have successfully run the following set of commands (replace $package with the name of the package that is submitted, $version is the version of the package you want to get into Stackage):

    stack unpack $package
    cd $package-$version
    stack init --resolver nightly
    stack build --resolver nightly --haddock --test --bench --no-run-benchmarks
    

The latest version of `dhall` builds against the latest version of `ansi-terminal`
@Gabriella439
Copy link
Contributor Author

I believe the CI failure indicates that Travis is now pulling in an unexpected version of GHC? I think it's unrelated to this change

@DanBurton
Copy link
Contributor

We've switched nightlies over to ghc 8.4.1 now. I restarted the travis build; it should be internally consistent on which ghc version it expects and uses now.

@DanBurton DanBurton closed this Mar 13, 2018
@DanBurton DanBurton reopened this Mar 13, 2018
@DanBurton
Copy link
Contributor

The Travis build now states the correct reason for failure. Many packages are currently absent from the nightlies, such as aeson, cryptonite, yaml, etc. We are working on adding them back in. Keep the PR open. I'll give you an update on this if there's any action to take on your end. Otherwise, I anticipate we'll be able to merge within a few days.

@DanBurton
Copy link
Contributor

I've been able to restore most of the deps needed to the build plan. However, the following are still an issue:

http-client (not present) depended on by:

http-client-tls (not present) depended on by:

trifecta (not present) depended on by:

All three are waiting on blaze-builder to upgrade. See also: lpsmith/blaze-builder#14

@Gabriella439
Copy link
Contributor Author

@DanBurton: Yeah, no hurry

Regarding #3143 (comment), should I wait for this to complete before opening an issue to add the dhall-* packages back to LTS 11?

@DanBurton
Copy link
Contributor

@Gabriel439 no need to wait. LTS 11 is still on ghc 8.2 and does already include blaze-builder. It will not have the same roadblock that we are experiencing here.

@DanBurton
Copy link
Contributor

The blaze-builder update happened, yay! It appears that the last issue blocking dhall is haskell/text-format#22

text-format (not present) depended on by:

@Gabriella439
Copy link
Contributor Author

Somebody contributed a fix to replace dhall's text-format dependency with a formatting dependency instead since text-format appears to be unmaintained, so I'm going to cut a new release with the changed dependency, which should fix this last issue. formatting seems to be maintained and already passing for Stackage nightly if I'm reading the build-constraints.yaml correctly

@DanBurton
Copy link
Contributor

formatting seems to be maintained and already passing for Stackage nightly if I'm reading the build-constraints.yaml correctly

@Gabriel439 correct.

https://www.stackage.org/nightly-2018-03-20/package/formatting-6.3.1

@Gabriella439
Copy link
Contributor Author

Alright, I updated dhall and its reverse dependencies to no longer depend on formatting and I verified that dhall builds with the latest stackage nightly

@juhp juhp merged commit 588381d into commercialhaskell:master Apr 1, 2018
@juhp
Copy link
Contributor

juhp commented Apr 1, 2018

Thanks, sorry this took so long: this one seemed to slip through the cracks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants