Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CWL v1.2: pickValue & when #43

Merged
merged 9 commits into from
Nov 12, 2020
Merged

CWL v1.2: pickValue & when #43

merged 9 commits into from
Nov 12, 2020

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Nov 11, 2020

Works for all pickValues. Also improves support for Union types.

@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #43 (a244aa3) into main (e2728a3) will increase coverage by 0.22%.
The diff coverage is 25.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   23.38%   23.60%   +0.22%     
==========================================
  Files          14       14              
  Lines       19097    19355     +258     
==========================================
+ Hits         4465     4569     +104     
- Misses      14632    14786     +154     
Impacted Files Coverage Δ
tests/test_docker_extract.py 57.69% <ø> (ø)
cwl_utils/cwl_v1_2_expression_refactor.py 14.72% <18.29%> (+0.60%) ⬆️
cwl_utils/cwl_v1_0_expression_refactor.py 15.10% <20.68%> (+0.98%) ⬆️
cwl_utils/cwl_v1_1_expression_refactor.py 15.12% <24.74%> (+1.01%) ⬆️
cwl_utils/parser_v1_1.py 22.75% <42.10%> (+0.30%) ⬆️
cwl_utils/parser_v1_2.py 21.79% <42.10%> (+0.28%) ⬆️
cwl_utils/parser_v1_0.py 29.38% <50.00%> (+<0.01%) ⬆️
tests/test_etools_to_clt.py 88.46% <62.50%> (-11.54%) ⬇️
cwl_utils/graph_split.py 51.02% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2728a3...a244aa3. Read the comment docs.

Doesn't yet pull out expressions from 'when'.

Better support for union types.
@mr-c mr-c changed the title CWL v1.2: pickValue CWL v1.2: pickValue & when Nov 12, 2020
@mr-c mr-c marked this pull request as ready for review November 12, 2020 18:05
@mr-c mr-c merged commit ca085e0 into main Nov 12, 2020
@mr-c mr-c deleted the pickValue branch November 12, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant