-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CWL v1.2: pickValue & when #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #43 +/- ##
==========================================
+ Coverage 23.38% 23.60% +0.22%
==========================================
Files 14 14
Lines 19097 19355 +258
==========================================
+ Hits 4465 4569 +104
- Misses 14632 14786 +154
Continue to review full report at Codecov.
|
Doesn't yet pull out expressions from 'when'. Better support for union types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works for all
pickValue
s. Also improves support for Union types.when
s that contain CWL expression to be references to a new step(Moved to expr refactor: pickValue on a Workflow step input #44 so we can get this merged)pickValue
on a Workflow step input.testingMoved to expr refactor: download conformance tests and process & run them #45_nojs
tests all convert and run as expected, exceptthe_only_non_null_multi_true_nojs
which succeeds when it shouldn't because the tool has "fixed" the problem of the missingInlineJavascriptRequirement
.