Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh with latest schema-salad, proposed CWL v1.2.1 changes #89

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Jun 26, 2022

Fixes #27 amongst other things

  • SavableSaveable typo fix changes some class names
  • default field type is now explicitly including File and Directory alongside Any
  • hints is now defined as any of the known requirements, or Any (should be a nice simplification)
  • the refscope for workflow outputSource was corrected from 0 to 1

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending CI, but looks good! 👍

@@ -19,7 +19,7 @@
/**
* Auto-generated interface for <I>https://w3id.org/cwl/cwl#InitialWorkDirRequirement</I><BR>This interface is implemented by {@link InitialWorkDirRequirementImpl}<BR> <BLOCKQUOTE>
Define a list of files and subdirectories that must be staged by the workflow platform prior to executing the command line tool.
Normally files are staged within the designated output directory. However, when running inside containers, files may be staged at arbitrary locations, see discussion for `Dirent.entryname`. Together with `DockerRequirement.dockerOutputDirectory` this it possible to control the locations of both input and output files when running in containers. </BLOCKQUOTE>
Normally files are staged within the designated output directory. However, when running inside containers, files may be staged at arbitrary locations, see discussion for [`Dirent.entryname`](#Dirent). Together with `DockerRequirement.dockerOutputDirectory` it is possible to control the locations of both input and output files when running in containers. </BLOCKQUOTE>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, maybe the markdown links could be rendered to HTML links in the future, at least for Java. Producing something like <a href="">{@code Dirent.entryName}</a> (not sure if {@code } can go there, but basically a markdown -> javadoc step). Similarly a markdown -> pydoc, and so it goes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea; see #93 for the follow up

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 62.481% when pulling 2235832 on refresh_schema into 673940d on cwl-1.2.0.

@mr-c mr-c merged commit 476b0c0 into cwl-1.2.0 Sep 1, 2022
@mr-c mr-c deleted the refresh_schema branch September 1, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

explore alternative schema with better ease of use for hints
3 participants