ci: Test with ASan and UBSan #534
Conversation
This adds a CI job that tests with clang, ASan and UBSan. Only the static build is supported for now.
Since we run our tests through Python, this requires - to link with -shared-libasan - to LD_PRELOAD the ASan runtime - to disable LeakSanitizer beacuse of false positives from Python
|
Maybe we should discuss this before merging. Here's a more invasive change that enables sanitizers on all OSs and compilers: https://github.com/nwellnhof/cmark/blob/asan2/.github/workflows/ci.yml |
|
So, is the question here whether we want the minimal change or the one that tests with sanitizers on all OSs/compilers? What is the drawback to the latter option? |
|
The new proposal now updated with a full os/compiler/build_type/sanitizer matrix: https://github.com/nwellnhof/cmark/blob/asan2/.github/workflows/ci.yml Test results: https://github.com/nwellnhof/cmark/actions/runs/8321495139 |
|
I'll post a new PR. |
|
Are there any drawbacks to using this full matrix? I wasn't sure what you had in mind when you suggested discussion. |
Not really. The full matrix runs a few more jobs than before. |
This adds a CI job that tests with clang, ASan and UBSan. Only the static build is supported for now, meaning that we miss a few tests.
I happened to run into a very recent and probably short-lived issue with Github runners: actions/runner-images#9491. The work-around can probably be removed soon.
We could also consider removing the valgrind test now.