ci: Test with ASan and rework CI matrix #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add CI tests with -fsanitize=address,undefined. This is a bit
complicated since our tests run through Python FFI and we have to
- link with -shared-libasan
- preload the ASan runtime
- disable LeakSanitizer because of false positives from Python
Use a single matrix on POSIX with four human readable labels:
posix (os, compiler, build_type, sanitizers)
Disable gcc on macOS which is just an alias for clang.
Remove the valgrind leakcheck test. This should be covered now
by testing with LeakSanitizer on static builds, including tests
like spectest_executable. The full test suite is only available
to shared library builds which have to run without leak checks
for now.
Also rework the Windows matrix.
|
Github action page: https://github.com/commonmark/cmark/actions/runs/8321937012 |
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CI tests with -fsanitize=address,undefined. This is a bit complicated since our tests run through Python FFI and we have to
Use a single matrix on POSIX with four human readable labels:
Disable gcc on macOS which is just an alias for clang.
Remove the valgrind leakcheck test. This should be covered now by testing with LeakSanitizer on static builds, including tests like spectest_executable. The full test suite is only available to shared library builds which have to run without leak checks for now.
Also rework the Windows matrix.