Misc cleanup #536
Merged
Misc cleanup #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The full test suite is only available to a shared library build.
Functions are extern by default.
jgm
reviewed
Mar 24, 2024
Comment on lines
-28
to
-29
| extern int houdini_escape_html(cmark_strbuf *ob, const uint8_t *src, | ||
| bufsize_t size); |
There was a problem hiding this comment.
In addition to removing this, would it make sense to rename houdini_escape_html0 to houdini_escape_html?
There was a problem hiding this comment.
Yes, this would make sense.
jgm
added a commit
that referenced
this pull request
Mar 25, 2024
See #536. Due to a mistake this change is spread over two separate commits.
jgm
added a commit
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.