Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bruig: sync flutter_markdown and scrollable_positioned_list #251

Merged
merged 1 commit into from
May 29, 2023
Merged

bruig: sync flutter_markdown and scrollable_positioned_list #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions bruig/flutterui/bruig/lib/components/chat/messages.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,14 +168,16 @@ class _MessagesState extends State<Messages> {
var backgroundColor = theme.backgroundColor;
return Scaffold(
floatingActionButton: _getFAB(textColor, backgroundColor),
body: ScrollablePositionedList.builder(
itemCount: chat.msgs.length,
physics: const ClampingScrollPhysics(),
itemBuilder: (context, index) {
return Event(chat, chat.msgs[index], nick, client, _scrollToBottom);
},
itemScrollController: widget.itemScrollController,
itemPositionsListener: widget.itemPositionsListener,
body: SelectionArea(
child: ScrollablePositionedList.builder(
itemCount: chat.msgs.length,
physics: const ClampingScrollPhysics(),
itemBuilder: (context, index) {
return Event(chat, chat.msgs[index], nick, client, _scrollToBottom);
},
itemScrollController: widget.itemScrollController,
itemPositionsListener: widget.itemPositionsListener,
),
),
);
}
Expand Down
13 changes: 6 additions & 7 deletions bruig/flutterui/bruig/pubspec.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ packages:
description:
path: "packages/flutter_markdown"
ref: main
resolved-ref: ef6b5a380e0d6fa2705c1b19e5613c60db01bfd0
resolved-ref: b98386c14fef19537a8b45a232c6b04c8cf49acd
url: "https://github.com/tiagoalvesdulce/packages"
source: git
version: "0.6.14+1"
Expand Down Expand Up @@ -531,12 +531,11 @@ packages:
scrollable_positioned_list:
dependency: "direct main"
description:
path: "packages/scrollable_positioned_list"
ref: HEAD
resolved-ref: f4981ba61c491955cca7b73916aa05c9fbf2056f
url: "https://github.com/tiagoalvesdulce/flutter.widgets"
source: git
version: "0.3.5"
name: scrollable_positioned_list
sha256: "1b54d5f1329a1e263269abc9e2543d90806131aa14fe7c6062a8054d57249287"
url: "https://pub.dev"
source: hosted
version: "0.3.8"
shared_preferences:
dependency: "direct main"
description:
Expand Down
5 changes: 1 addition & 4 deletions bruig/flutterui/bruig/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,7 @@ dependencies:
package_info_plus: ^3.0.3
open_filex: ^4.3.2
loading_animation_widget: ^1.2.0
scrollable_positioned_list:
git:
url: https://github.com/tiagoalvesdulce/flutter.widgets
path: packages/scrollable_positioned_list
scrollable_positioned_list: ^0.3.8
flutter_markdown:
git:
url: https://github.com/tiagoalvesdulce/packages
Expand Down