Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client] Fix new day printing #139

Merged
merged 2 commits into from
Jan 4, 2019

Conversation

marcopeereboom
Copy link
Contributor

No description provided.

@jrick jrick self-requested a review January 2, 2019 15:44
@jrick
Copy link
Member

jrick commented Jan 2, 2019

Leaving this running overnight to see if it fixes the issue, but upon starting a new client instance, I already see day changed messages in-between two different messages on the same day. For example:

10:38:03 group conversation started: foo
10:38:03 <jrick> bar
10:38:19 first message received on 2 January 2019
10:38:19 <marco> baz

This is how the client has always operated, but it still seems like a bug to me. I would expect it to display:

10:38:03 group conversation started: foo
10:38:19 first message received on 2 January 2019 <- this is server time, not client time, and not sure what timestamp is actually best here
10:38:03 <jrick> bar
10:38:19 <marco> baz

or to just leave out the first day changed message entirely.

@marcopeereboom marcopeereboom merged commit 5925ced into companyzero:master Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants