Disable keepalives in server. #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server doesn't always seem to detect when a client disappears off the net. This diff adds a mechanism to knock current connections offline if a duplicate ID comes in. This is annoying when the user may accidentally have two zkclients open but it beats being locked out of zkserver for hours at a time.
dajohi
requested changes
Aug 6, 2019
zkserver/zkserver.go
Outdated
| z.Dbg(idS, "handleSession forced offline: %v", rids) | ||
| z.Lock() | ||
| oldSc, ok := z.sessions[rids] | ||
| if ok { |
There was a problem hiding this comment.
can get rid of if else if you just do a if !ok instead.
| @@ -659,8 +700,7 @@ func (z *ZKS) listen() error { | |||
| continue | |||
| } | |||
|
|
|||
| conn.(*net.TCPConn).SetKeepAlive(true) | |||
| conn.(*net.TCPConn).SetKeepAlivePeriod(time.Second) | |||
| conn.(*net.TCPConn).SetKeepAlive(false) | |||
There was a problem hiding this comment.
recommend just removing altogether
There was a problem hiding this comment.
I like it being explicit and I don't know what the OS is doing underneath.
dajohi
approved these changes
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable keep-alives and cull online connections on repeated client connections.
Fixes #149