Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning about ehs and ehc being switch to ehs- and ehc- #445

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mcbarton
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

I won't know for sure until the ci has run, but the objective of this PR is to fix the warning here https://github.com/compiler-research/CppInterOp/actions/runs/12736900694/job/35497330109#step:8:144 about ehs and ehc being overridden with ehs- and ehc-

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.17%. Comparing base (c9499ae) to head (fdf6f40).
Report is 42 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
+ Coverage   70.96%   71.17%   +0.20%     
==========================================
  Files           9        9              
  Lines        3541     3552      +11     
==========================================
+ Hits         2513     2528      +15     
+ Misses       1028     1024       -4     

see 4 files with indirect coverage changes

see 4 files with indirect coverage changes

@mcbarton mcbarton marked this pull request as draft January 12, 2025 23:38
@mcbarton
Copy link
Collaborator Author

Removed some of the warnings but not all. I will revisit soon to get the rest of the warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant