Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install missing dependencies osx jobs to fix osx ci workflows #496

Closed
wants to merge 6 commits into from

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Feb 4, 2025

Description

Please include a summary of changes, motivation and context for this PR.

This PR updates the dependencies installed on osx jobs to match those added in compiler-research/cppyy#125 . This should fix the osx workflows so they pass. As of writing this PR the emscripten workflow is broken, so this workflow is not expected to pass for this PR.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.17%. Comparing base (a901f57) to head (d013cd1).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #496   +/-   ##
=======================================
  Coverage   71.17%   71.17%           
=======================================
  Files           9        9           
  Lines        3552     3552           
=======================================
  Hits         2528     2528           
  Misses       1024     1024           

@mcbarton mcbarton marked this pull request as draft February 4, 2025 23:11
@mcbarton mcbarton closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant