Skip to content

Commit

Permalink
[test] update tags (#119)
Browse files Browse the repository at this point in the history
fixed by compiler-research/CPyCppyy#74 & #121
`test19_keywords_and_defaults` fixed by compiler-research/CPyCppyy#73
  • Loading branch information
Vipul-Cariappa authored and aaronj0 committed Jan 22, 2025
1 parent 3a30ebc commit f18794a
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion test/test_advancedcpp.py
Original file line number Diff line number Diff line change
Expand Up @@ -722,7 +722,7 @@ def test21_access_to_global_variables(self):
assert len(cppyy.gbl.gtestv1) == 1
assert len(cppyy.gbl.gtestv2) == 1

@mark.xfail(run=not IS_MAC_ARM, reason="Crashes with exception not being caught on Apple Silicon")
@mark.xfail(run=False, condition=IS_MAC_ARM, reason="Crashes with exception not being caught on Apple Silicon")
def test22_exceptions(self):
"""Catching of C++ exceptions"""

Expand Down
4 changes: 2 additions & 2 deletions test/test_doc_features.py
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ def abstract_method2(self):
assert cppyy.gbl.call_abstract_method1(pc) == "first message"
assert cppyy.gbl.call_abstract_method2(pc) == "second message"

@mark.xfail(run=not IS_MAC_ARM, reason="Crashes with exception not being caught on Apple Silicon")
@mark.xfail(run=False, condition=IS_MAC_ARM, reason="Crashes with exception not being caught on Apple Silicon")
def test_exceptions(self):
"""Exception throwing and catching"""

Expand Down Expand Up @@ -1242,7 +1242,7 @@ def test_autocast_and_identiy(self):
assert type(b) == CC.Derived
assert d is b

@mark.xfail(run=not IS_MAC_ARM, reason="Seg Faults")
@mark.xfail(condition=IS_MAC_ARM, run=False, reason="Seg Faults")
def test_exceptions(self):
"""Exceptions example"""

Expand Down
2 changes: 1 addition & 1 deletion test/test_overloads.py
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ def test09_bool_int_overloads(self):
with raises(ValueError):
cpp.BoolInt4.fff(2)

@mark.xfail(run=not IS_MAC_ARM, reason="Seg Faults")
@mark.xfail(run=not IS_MAC_ARM, condition=IS_MAC, reason="Seg Faults")
def test10_overload_and_exceptions(self):
"""Prioritize reporting C++ exceptions from callee"""

Expand Down
2 changes: 1 addition & 1 deletion test/test_pythonify.py
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ def verify_b(b, val, ti, to):
with raises(TypeError):
c.callme(a=1, b=2)

@mark.xfail
@mark.xfail(condition=(not IS_CLANG_REPL) or IS_MAC, reason="Fails on Cling and OSX")
def test19_keywords_and_defaults(self):
"""Use of keyword arguments mixed with defaults"""

Expand Down
2 changes: 1 addition & 1 deletion test/test_stltypes.py
Original file line number Diff line number Diff line change
Expand Up @@ -2030,7 +2030,7 @@ def run_raiseit(t1, t2):
gc.collect()
assert cppyy.gbl.GetMyErrorCount() == 0

@mark.xfail(run=not IS_MAC_ARM, reason="Seg Faults")
@mark.xfail(condition=(IS_MAC_X86 and not IS_CLANG_REPL) or IS_MAC_ARM, run=not IS_MAC_ARM, reason="Seg Faults")
def test04_from_cpp(self):
"""Catch C++ exceptiosn from C++"""

Expand Down

0 comments on commit f18794a

Please sign in to comment.