Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fresco #75

Merged
merged 33 commits into from
Oct 9, 2023
Merged

Fresco #75

merged 33 commits into from
Oct 9, 2023

Conversation

jthrilly
Copy link
Member

@jthrilly jthrilly commented Oct 5, 2023

This PR represents a significant refactor of the protocol-validation repo.

  • Converts the majority of the project to typescript
  • Provides a clean and consistent return interface for the ajv based validation
  • Provides a clean validateProtocol method that combines schema and logic based validation
  • Dropped support for schema 1.0.0 (string format). This format was hardly used and isn't supported
  • Fixed several invalid schema definitions that have been historically present.
  • Uses a dynamic import during the validation process to only load the schema file that is required. This cuts the initial import down to 14kb, and the total for validation to roughly 160kb. Previously this was 1mb+.

Other changes:

  • Switched the runtime to bun from node. Note that this required disabling some tests, which were checked beforehand to ensure they pass in the node runtime. These will be reinstated ASAP.
  • Updated all project dependencies.
  • Updated eslint configuration to match current best practices

@jthrilly jthrilly merged commit 808d748 into master Oct 9, 2023
1 check passed
@jthrilly jthrilly deleted the fresco branch November 1, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant