PSCE-408 refactor: replaces regex with urllib for repo URL parsing #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a dedicated library for url parsing is generally less error prone and easier to maintain Signed-off-by: Jennifer Power <[email protected]>
Resolves type errors in python 3.8 Signed-off-by: Jennifer Power <[email protected]>
jpower432
changed the title
14 tasks
gvauter
approved these changes
May 7, 2024
trestlebot/provider.py
Outdated
| def match_url(self, repo_url: str) -> Tuple[Optional[re.Match[str]], str]: | ||
| """Match a repository URL with the pattern""" | ||
| parsed_url: ParseResult = urlparse(repo_url) | ||
| scheme = parsed_url.scheme |
There was a problem hiding this comment.
Just a nit-pick comment so feel free to ignore. These could be summarized to reduce verbosity. Ex:
if host := parsed_url.hostname:
stripped_url = f"{host}{path}"
if scheme := parsed_url.scheme:
stripped_url = f"{scheme}://{stripped_url}"
There was a problem hiding this comment.
Thanks @gvauter. I will apply this.
Signed-off-by: Jennifer Power <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
GitProviderclass and concrete implementations, move any repo url string parsing tourlliband only use regex for path pattern matching and capturing. Also removesregexrelated code smell.Prep for #200
Type of change
How has this been tested?
Checklist