-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE8 Support #159
base: master
Are you sure you want to change the base?
IE8 Support #159
Conversation
It should be noted that I ran the full test suite and got a pass:
|
Yea, automatic travis CI tests never work because of the secure ENV variables in the travis config. |
This is brilliant. I will review in more detail tonight and merge. |
the latest commit updates to a simpler set of shims (version 0.1.2 of reactive-ie8-shims). It removes |
I have successfully gotten a full pass in IE8 for reactive. To do so, I needed to include #158, make some small adjustments to tests and code, and include a ton of shims. I did this by creating a separate repository: reactive-ie8-shims, which can be included via browserify or prebuilt scripts. Simply shim it in before running any reactive code and you're golden!