Add some API design notes and API skeletons for Dir module #2973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adithyaov
force-pushed
the
dir-API
branch
3 times, most recently
from
50d4697 to
3aedcd0
Compare
harendra-kumar
commented
Feb 18, 2025
adithyaov
force-pushed
the
dir-API
branch
2 times, most recently
from
8643dbc to
0d2041f
Compare
harendra-kumar
commented
Feb 18, 2025
| foreign import ccall unsafe "stat.h lstat" | ||
| c_lstat :: CString -> Ptr CStat -> IO CInt | ||
|
|
||
| foreign import ccall unsafe "stat.h stat" |
There was a problem hiding this comment.
wondering if this should be capi instead?
adithyaov
force-pushed
the
dir-API
branch
2 times, most recently
from
186781b to
dd8bdbe
Compare
harendra-kumar
commented
Feb 19, 2025
- Use dummy ReadOptions in Windows - Use hsc constructs directly instead of using C FFI - Update the tests and benchmarks - Add symlink related tests
harendra-kumar
commented
Feb 19, 2025
|
|
||
| -- | Checks if dname is a directory and additionaly returns if dname is a meta | ||
| -- directory. | ||
| {-# INLINE checkDirStatus #-} | ||
| checkDirStatus | ||
| :: PosixPath -> Ptr CChar -> #{type unsigned char} -> IO (Bool, Bool) | ||
| :: ReadOptions | ||
| -> PosixPath -> Ptr CChar -> #{type unsigned char} -> IO GStatRes | ||
| #ifdef FORCE_LSTAT_READDIR |
There was a problem hiding this comment.
We can remove this flag now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.