Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll and Scroll testnet deployment + proposals #813

Merged
merged 14 commits into from
Mar 28, 2024

Revert some more unnecessary diffs in hardhat.config.ts

24f5ac3
Select commit
Loading
Failed to load commit list.
Merged

Scroll and Scroll testnet deployment + proposals #813

Revert some more unnecessary diffs in hardhat.config.ts
24f5ac3
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Semgrep OSS succeeded Mar 28, 2024 in 3s

13 new alerts

New alerts in code changed by this pull request

  • 1 warning
  • 12 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 22 in contracts/bridges/scroll/ScrollBridgeReceiver.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.non-payable-constructor Note

Consider making costructor payable to save gas.

Check warning on line 22 in contracts/bridges/scroll/ScrollBridgeReceiver.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: compound.solidity.missing-constructor-sanity-checks Warning

There're no sanity checks for the constructor argument l2Messenger_.

Check notice on line 202 in contracts/ScrollComet.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.non-payable-constructor Note

Consider making costructor payable to save gas.

Check notice on line 367 in contracts/ScrollComet.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-prefix-increment-not-postfix Note

Consider using the prefix increment expression whenever the return value is not needed.
The prefix increment expression is cheaper in terms of gas.

Check notice on line 535 in contracts/ScrollComet.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-prefix-increment-not-postfix Note

Consider using the prefix increment expression whenever the return value is not needed.
The prefix increment expression is cheaper in terms of gas.

Check notice on line 577 in contracts/ScrollComet.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-prefix-increment-not-postfix Note

Consider using the prefix increment expression whenever the return value is not needed.
The prefix increment expression is cheaper in terms of gas.

Check notice on line 630 in contracts/ScrollComet.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-nested-if Note

Using nested is cheaper than using && multiple check combinations.
There are more advantages, such as easier to read code and better coverage reports.

Check notice on line 735 in contracts/ScrollComet.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-nested-if Note

Using nested is cheaper than using && multiple check combinations.
There are more advantages, such as easier to read code and better coverage reports.

Check notice on line 735 in contracts/ScrollComet.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-nested-if Note

Using nested is cheaper than using && multiple check combinations.
There are more advantages, such as easier to read code and better coverage reports.

Check notice on line 1113 in contracts/ScrollComet.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-prefix-increment-not-postfix Note

Consider using the prefix increment expression whenever the return value is not needed.
The prefix increment expression is cheaper in terms of gas.

Check notice on line 1122 in contracts/ScrollComet.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-prefix-increment-not-postfix Note

Consider using the prefix increment expression whenever the return value is not needed.
The prefix increment expression is cheaper in terms of gas.

Check notice on line 1154 in contracts/ScrollComet.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-prefix-increment-not-postfix Note

Consider using the prefix increment expression whenever the return value is not needed.
The prefix increment expression is cheaper in terms of gas.

Check notice on line 1198 in contracts/ScrollComet.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-nested-if Note

Using nested is cheaper than using && multiple check combinations.
There are more advantages, such as easier to read code and better coverage reports.