Fix roku-hdhomerun on SD displays #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an older Roku 2100X (XD|S) with 3.1 firmware alongisde a Roku HDMI Stick. They receive OTA TV via a HDTC-2US through the ply server.
When the 2100X is set to 4:3 display, roku-hdhomerun streams but never displays video, because:
"The StreamQuality attribute is used to select streams and indicates if a stream is HD or not. If the attribute for HDBranded is set to true and the stream is HD, the HD icon will show beside the quality dots. If the StreamQuality is set to HD, and the user display type is set to SD, the HD stream will not be selected."
(http://sdkdocs.roku.com/display/sdkdoc/roVideoScreen)
Therefore I have added a function (in utils.brs) that detects what display type the roku is set to. StreamQuality is then set to that value so that the stream is played on both HD and SD screen-types. I have also created and added the missing manifest .pngs so the HDHomeRun icon will display on the MainMenu in older firmwares.
Finally, using the same function, and some glue I added to ply server, (pompous-stranger/ply@themacks:master...master) I attached a query to the wallop POST/tune channel method to tell ply what display type it was streaming to, so it could select the optimal SD/HD video transcode for roku-hdhomerun. Something similar could probably be done to wallop. Currently wallop appears to ignore the query in my testing, so this change shouldn't be destructive.