Clarify and simplify README #38
Conversation
|
conflicts need to be resolved. @TheChymera please review it soon so it could be merged to avoid conflicts to keep coming up |
|
should have this marked as WIP, but is now ready to review. Following these steps I got a full reanalysis and meta-article generation this morning. |
asmacdo
force-pushed
the
asmacdoify-readme
branch
from
73f93d5
to
c03c0cc
Compare
|
@asmacdo there are a bunch of comments by me above @yarikoptic 's comment. Are they not visible to you guys? |
|
@TheChymera dont see them, did you start a "review"? |
|
did you submit the started review? |
| @@ -19,8 +19,8 @@ ifeq ($(SCRATCH_PATH),) | |||
| SCRATCH_PATH = $(PWD)/scratch | |||
| endif | |||
|
|
|||
| OCI_BINARY=docker | |||
| SING_BINARY=singularity | |||
| OCI_BINARY?=docker | |||
There was a problem hiding this comment.
What does this do differently? = here won't overwrite the variable if you set it.
There was a problem hiding this comment.
Interesting, for me
THE_VAR=foo
.PHONY:
test-env-var:
echo ${THE_VAR}
THE_VAR is foo, even if I export THE_VAR=somethingelse
When I added the ?= it started working.
There was a problem hiding this comment.
strange, ok, let's leave it like that then.
|
Ah, ok, they were saved but I needed to press another button to publish them. These are from yesterday morning, I think one is outdated, let me read again. |
README.md
Outdated
| - python3-yaml | ||
|
|
||
| You will also need to install sourceserifpro font using the tlmgr. | ||
| TODO(chymera): audit |
There was a problem hiding this comment.
the list of requirements, since you installed locally
There was a problem hiding this comment.
@asmacdo ok, can you deal with the rest and I'll figure that one out?
There was a problem hiding this comment.
sourceserifpro doesnt appear to be required to finish building anymore. I added this so it would finish building, but this font is listed explicitly as a requirement in rescience.cls
I don't mind if youd like to remove it but lets do that in a separate pr.
| - python3-statsmodels | ||
| - python3-yaml | ||
|
|
||
| You will also need to install sourceserifpro font using the tlmgr. |
Previous version mistakenly assumed that output pdfs do not need to be retrieved via datalad if the pdf is regenerated. Even if an OPFVTA article pdf is generated, we still must retrieve the earlier versons in order to execute the comparison.
asmacdo
force-pushed
the
asmacdoify-readme
branch
from
c03c0cc
to
0d6b681
Compare
@TheChymera I was pretty liberal in my slashing so lmk if you want to keep any of this.