ginkgo: disable autodiscovery of ccache + fix build of 1.7.0 with msvc & C++20 #21626

SpaceIm · 2023-12-05T22:45:29Z

Disable autodiscovery and usage of ccache in ginkgo build. ccache usage in conancenter recipes must be opt-in.
See https://github.com/ginkgo-project/ginkgo/blob/v1.4.0/CMakeLists.txt#L53 and https://github.com/ginkgo-project/ginkgo/blob/v1.4.0/CMakeLists.txt#L104-L112
Fix build of ginkgo 1.7.0 with msvc & C++20 (see ginkgo 1.7.0: Compilation with Visual Studio 2022 and C++20 fails 'uncaught_exception': is not a member of 'std' ginkgo-project/ginkgo#1495 and upstream fix ginkgo-project/ginkgo@876d8ff)

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

recipes/ginkgo/all/conanfile.py

github-actions · 2023-12-11T17:41:45Z

Hooks produced the following warnings for commit e7eeec9

ginkgo/1.4.0@#6f6179da48d23e49c9db63c6319bb86c

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_ompd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_hipd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_cudad.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_deviced.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgod.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_dpcppd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_referenced.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_dpcpp.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_reference.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_hip.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_device.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_cuda.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_omp.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo.so' links to system library 'm' but it is not in cpp_info.system_libs.

ginkgo/1.7.0@#347f9e766cac0b4fc48bf03d9250a629

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_ompd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_hipd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_cudad.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_deviced.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgod.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_dpcppd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_referenced.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_dpcpp.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_reference.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_hip.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_device.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_cuda.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_omp.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo.so' links to system library 'm' but it is not in cpp_info.system_libs.

ginkgo/1.3.0@#58ca9260bb9b38e80603ba9212e40ff9

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_ompd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_hipd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_cudad.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgod.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_referenced.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_reference.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_hip.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_cuda.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo_omp.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libginkgo.so' links to system library 'm' but it is not in cpp_info.system_libs.

AbrilRBS

Thanks! Quick question

AbrilRBS · 2024-01-06T04:29:24Z

recipes/ginkgo/all/conanfile.py

+                self.output.warning(
+                    f"You asked for Ninja generator, but fallback to {visual_generator}, "
+                    "otherwise it will fail during creation of DLL with "
+                    "LINK : fatal error LNK1189: library limit of 65535 objects exceeded"
+                )


Thinking about it now, this might be confussing behaviour - were there any objetctions to raising in validate() for this case?

As a consumer I consider that CMake generator is a wish for an internal detail and has no impact on produced binaries, so I don't care if it's not honored. I prefer a simple conan install command so that it can work out of the box, instead of "die and retry" iterations in order to find correct conan command to install my dependencies.

So sure we could raise, but I believe it would be a bad user experience.

Conan v1 pipeline ✔️

All green in build 3 (2450c7398f4ce963b5cd527a87ec07dd103a186c):

ginkgo/1.8.0:
Built 21 packages out of 22 (All logs)
ginkgo/1.7.0:
Built 21 packages out of 22 (All logs)
ginkgo/1.3.0:
All packages built successfully! (All logs)
ginkgo/1.4.0:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (2450c7398f4ce963b5cd527a87ec07dd103a186c):

ginkgo/1.7.0:
Built 8 packages out of 10 (All logs)
ginkgo/1.8.0:
Built 8 packages out of 10 (All logs)
ginkgo/1.4.0:
Built 8 packages out of 10 (All logs)
ginkgo/1.3.0:
Built 8 packages out of 10 (All logs)

disable autodiscovery of ccache

52dbba8

prince-chrismc mentioned this pull request Dec 5, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

SpaceIm changed the title ~~ginkgo: disable autodiscovery of ccache~~ ginkgo: disable autodiscovery of ccache + fix build of 1.7.0 with msvc & C++20 Dec 6, 2023

fix compilation of ginkgo 1.7.0 with msvc & C++20

7739e37

SpaceIm force-pushed the ginkgo-disable-ccache branch from 9d17a69 to 7739e37 Compare December 6, 2023 00:25

conan-center-bot added the Failed label Dec 6, 2023

This comment has been minimized.

Sign in to view

SpaceIm added 4 commits December 6, 2023 01:56

typo

81cc722

workaround for msvc shared if Ninja generator set by user

cda6743

add warning message

dfaad28

update patch_source of 1.7.0-0002-msvc-c++20.patch

834a4a7

upsj reviewed Dec 6, 2023

View reviewed changes

recipes/ginkgo/all/conanfile.py Show resolved Hide resolved

improve _get_visual_generator

e7eeec9

conan-center-bot added the Unexpected Error label Dec 8, 2023

This comment has been minimized.

Sign in to view

conan-center-bot removed Unexpected Error Failed labels Dec 11, 2023

This comment has been minimized.

Sign in to view

add system_libs

234dc7a

This comment has been minimized.

Sign in to view

conan-center-bot requested a review from uilianries December 12, 2023 11:40

jwillikers approved these changes Dec 18, 2023

View reviewed changes

AbrilRBS reviewed Jan 6, 2024

View reviewed changes

AbrilRBS self-assigned this Jan 6, 2024

conan-center-bot requested a review from jcar87 January 30, 2024 11:41

valgur approved these changes Mar 24, 2024

View reviewed changes

conan-center-bot requested a review from franramirez688 April 22, 2024 11:41

conan-center-bot requested a review from danimtb June 3, 2024 11:41

Merge branch 'master' into ginkgo-disable-ccache

dde6462

conan-center-bot added the Failed label Aug 29, 2024

This comment has been minimized.

Sign in to view

Empty commit

7f4b637

conan-center-bot removed the Failed label Aug 29, 2024

This comment has been minimized.

Sign in to view

SpaceIm requested a review from AbrilRBS August 29, 2024 22:56

danimtb previously approved these changes Sep 6, 2024

View reviewed changes

jwillikers approved these changes Sep 10, 2024

View reviewed changes

handle compiler.version=194 for msvc

2450c73

SpaceIm dismissed danimtb’s stale review via 2450c73 September 22, 2024 17:58

jwillikers approved these changes Sep 26, 2024

View reviewed changes

valgur approved these changes Sep 26, 2024

View reviewed changes

Merge branch 'master' into ginkgo-disable-ccache

ae5252c

ErniGH added the look into label Nov 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ginkgo: disable autodiscovery of ccache + fix build of 1.7.0 with msvc & C++20 #21626

ginkgo: disable autodiscovery of ccache + fix build of 1.7.0 with msvc & C++20 #21626

SpaceIm commented Dec 5, 2023 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 11, 2023

This comment has been minimized.

AbrilRBS left a comment

AbrilRBS Jan 6, 2024

SpaceIm Jan 6, 2024

SpaceIm Jan 6, 2024

valgur left a comment

This comment has been minimized.

This comment has been minimized.

SpaceIm commented Sep 11, 2024 •

edited

Loading

AbrilRBS commented Sep 11, 2024

conan-center-bot commented Sep 22, 2024

ginkgo: disable autodiscovery of ccache + fix build of 1.7.0 with msvc & C++20 #21626

Are you sure you want to change the base?

ginkgo: disable autodiscovery of ccache + fix build of 1.7.0 with msvc & C++20 #21626

Conversation

SpaceIm commented Dec 5, 2023 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 11, 2023

This comment has been minimized.

AbrilRBS left a comment

Choose a reason for hiding this comment

AbrilRBS Jan 6, 2024

Choose a reason for hiding this comment

SpaceIm Jan 6, 2024

Choose a reason for hiding this comment

SpaceIm Jan 6, 2024

Choose a reason for hiding this comment

valgur left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

SpaceIm commented Sep 11, 2024 • edited Loading

AbrilRBS commented Sep 11, 2024

conan-center-bot commented Sep 22, 2024

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

SpaceIm commented Dec 5, 2023 •

edited

Loading

SpaceIm commented Sep 11, 2024 •

edited

Loading