Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ginkgo: disable autodiscovery of ccache + fix build of 1.7.0 with msvc & C++20 #21626
base: master
Are you sure you want to change the base?
ginkgo: disable autodiscovery of ccache + fix build of 1.7.0 with msvc & C++20 #21626
Changes from 8 commits
52dbba8
7739e37
81cc722
cda6743
dfaad28
834a4a7
e7eeec9
234dc7a
dde6462
7f4b637
2450c73
ae5252c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about it now, this might be confussing behaviour - were there any objetctions to raising in
validate()
for this case?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a consumer I consider that CMake generator is a wish for an internal detail and has no impact on produced binaries, so I don't care if it's not honored. I prefer a simple conan install command so that it can work out of the box, instead of "die and retry" iterations in order to find correct conan command to install my dependencies.
So sure we could raise, but I believe it would be a bad user experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see also conan-io/conan#12669 (comment)