Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getdns: migrate to Conan v2, bump to v1.7.3 #21389

Merged
merged 24 commits into from
Sep 6, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Nov 26, 2023

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Nov 27, 2023
@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Nov 27, 2023
@conan-center-bot conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Jan 2, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Jan 20, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

I did some changes over this PR, including:

  • Replaced cmake wrapper by CMAKE_PROJECT_INCLUDE to include external dependencies
  • Simplified test package to avoid fetching the network
  • Remove option for tls: GnuTLS is only supported on Linux and needs libnuma to work. Checking other package managers, only Gentoo is supporting it, and still, has a separated package for gnutls-numa
  • Remove stub option and configured to True always. Other package managers are using True as well, and CCI has no libunbound available
  • Enable libidn2 by default, following the upstream
  • Injected compiler flag to ignore pointer error on Clang (reported to the upstream)
  • Imported libidn2 definition when building on Windows to avoid linkage error.

@uilianries uilianries self-assigned this Sep 5, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

uilianries
uilianries previously approved these changes Sep 6, 2024
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valgur
Copy link
Contributor Author

valgur commented Sep 6, 2024

LGTM as well. Thanks!

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 7 (6092f1d143ca2e1f14dcbd1e6cb012cd9434e0d7):

  • getdns/1.7.3:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 6 (6092f1d143ca2e1f14dcbd1e6cb012cd9434e0d7):

  • getdns/1.7.3:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit d1ce33f into conan-io:master Sep 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants