-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getdns: migrate to Conan v2, bump to v1.7.3 #21389
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
valgur
commented
Nov 26, 2023
•
edited
Loading
edited
- Requires libidn2: migrate to Conan v2, add shared MSVC build #18642
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
valgur
force-pushed
the
migrate/getdns
branch
from
November 27, 2023 18:20
25c4f69
to
0b89c31
Compare
conan-center-bot
added
the
Missing dependencies
Build failed due missing dependencies in Conan Center
label
Nov 27, 2023
This comment has been minimized.
This comment has been minimized.
conan-center-bot
removed
the
Missing dependencies
Build failed due missing dependencies in Conan Center
label
Jan 2, 2024
This comment has been minimized.
This comment has been minimized.
valgur
force-pushed
the
migrate/getdns
branch
from
January 19, 2024 21:34
0b89c31
to
423eac2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
conan-center-bot
added
the
Missing dependencies
Build failed due missing dependencies in Conan Center
label
Jan 20, 2024
This comment has been minimized.
This comment has been minimized.
valgur
force-pushed
the
migrate/getdns
branch
from
January 23, 2024 19:59
fbb5e35
to
8a51ac1
Compare
This comment has been minimized.
This comment has been minimized.
conan-center-bot
added
Service Under Maintenance
and removed
Failed
Missing dependencies
Build failed due missing dependencies in Conan Center
labels
Feb 21, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jwillikers
approved these changes
Mar 25, 2024
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
I did some changes over this PR, including:
|
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <[email protected]>
… into migrate/getdns
Signed-off-by: Uilian Ries <[email protected]>
This comment has been minimized.
This comment has been minimized.
uilianries
previously approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM as well. Thanks! |
Signed-off-by: Uilian Ries <[email protected]>
uilianries
approved these changes
Sep 6, 2024
AbrilRBS
approved these changes
Sep 6, 2024
Conan v1 pipeline ✔️All green in build 7 (
Conan v2 pipeline ✔️
All green in build 6 (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.