Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vulkan-validationlayers: update versions, improve package_type and test_package #21495

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Nov 30, 2023

The package really only exports a VkLayer_khronos_validation runtime library and a .json manifest file, especially so after the utility library has been split off into vulkan-utility-libraries (#21059).

I adjusted the package_type accordingly to application and updated test_package to test the correct thing.

I intended to update the list of versions to match the other recently updated Vulkan and SPIRV packages (meaning only v1.3.239+ SDK versions), but:

  • 1.3.261.1 was not available in vulkan-loader for test_package.
  • 1.3.250.0 was not available in spirv-headers and spirv-tools.
  • 1.3.239.0 failed to load the validation layers in test_package and I'm not familiar enough with Vulkan to debug it.
  • 1.3.268.0 requires vulkan-utility-libraries: add new recipe #21059.

- 1.3.261 does not have vulkan-loaders available for testing.
- Loading the validation layer fails in test_package in 1.3.239 for some reason.
Requires vulkan-utility-libraries which has not been merged yet.
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request Jan 10, 2024
3 tasks
@ErniGH ErniGH self-requested a review June 11, 2024 12:46
@ErniGH ErniGH self-assigned this Jun 11, 2024
@ErniGH ErniGH removed their request for review June 11, 2024 12:46
…idationlayers

# Conflicts:
#	recipes/vulkan-validationlayers/all/conanfile.py
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 2 (7dd4f01d8b1c9b1b618daa2602c91ce08d9f5c8c):

  • vulkan-validationlayers/1.3.243.0:
    CI failed to create some packages (All logs)

    Logs for packageID b3f9974305c102445ab08078b43913a119072257:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=7
    os=Linux
    
    [...]
      the cmake_policy command to set the policy and suppress this warning.
    
    This warning is for project developers.  Use -Wno-dev to suppress it.
    
    CMake Warning at /home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/build/Release/generators/SPIRV-ToolsTargets.cmake:25 (message):
      Target name 'SPIRV-Tools' already exists.
    Call Stack (most recent call first):
      /home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/build/Release/generators/SPIRV-ToolsConfig.cmake:16 (include)
      layers/CMakeLists.txt:101 (find_package)
    
    
    VulkanVL_generated_source target requires python 3
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_POLICY_DEFAULT_CMP0091
    
    
    In file included from /home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/src/layers/generated/vk_format_utils.cpp:25:0:
    /home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/src/layers/./vk_layer_utils.h: In function ‘constexpr VkExtent3D GetEffectiveExtent(const VkImageCreateInfo&, VkImageAspectFlags, uint32_t)’:
    /home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/src/layers/./vk_layer_utils.h:399:27: error: call to non-constexpr function ‘bool FormatIsMultiplane(VkFormat)’
         if (FormatIsMultiplane(format)) {
             ~~~~~~~~~~~~~~~~~~^~~~~~~~
    make[2]: *** [layers/CMakeFiles/VkLayer_utils.dir/generated/vk_format_utils.cpp.o] Error 1
    make[2]: *** Waiting for unfinished jobs....
    In file included from /home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/src/layers/vk_layer_config.cpp:30:0:
    /home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/src/layers/vk_layer_utils.h: In function ‘constexpr VkExtent3D GetEffectiveExtent(const VkImageCreateInfo&, VkImageAspectFlags, uint32_t)’:
    /home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/src/layers/vk_layer_utils.h:399:27: error: call to non-constexpr function ‘bool FormatIsMultiplane(VkFormat)’
         if (FormatIsMultiplane(format)) {
             ~~~~~~~~~~~~~~~~~~^~~~~~~~
    In file included from /home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/src/layers/generated/vk_safe_struct.cpp:28:0:
    /home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/src/layers/./vk_layer_utils.h: In function ‘constexpr VkExtent3D GetEffectiveExtent(const VkImageCreateInfo&, VkImageAspectFlags, uint32_t)’:
    /home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/src/layers/./vk_layer_utils.h:399:27: error: call to non-constexpr function ‘bool FormatIsMultiplane(VkFormat)’
         if (FormatIsMultiplane(format)) {
             ~~~~~~~~~~~~~~~~~~^~~~~~~~
    make[2]: *** [layers/CMakeFiles/VkLayer_utils.dir/vk_layer_config.cpp.o] Error 1
    make[2]: *** [layers/CMakeFiles/VkLayer_utils.dir/generated/vk_safe_struct.cpp.o] Error 1
    make[1]: *** [layers/CMakeFiles/VkLayer_utils.dir/all] Error 2
    make: *** [all] Error 2
    WARN: **************************************************
    WARN: *** Conan 1 is legacy and on a deprecation path **
    WARN: *********** Please upgrade to Conan 2 ************
    WARN: **************************************************
    vulkan-validationlayers/1.3.243.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    vulkan-validationlayers/1.3.243.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    vulkan-validationlayers/1.3.243.0: ERROR: Package 'b3f9974305c102445ab08078b43913a119072257' build failed
    vulkan-validationlayers/1.3.243.0: WARN: Build folder /home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/build/Release
    ERROR: vulkan-validationlayers/1.3.243.0: Error in build() method, line 173
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build "/home/conan/workspace/prod-v1/bsr/97204/dcebb/.conan/data/vulkan-validationlayers/1.3.243.0/_/_/build/b3f9974305c102445ab08078b43913a119072257/build/Release" '--' '-j3'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@neobrain
Copy link
Contributor

FTR this has served me well while debugging some Vulkan issues under macOS with MoltenVK. Happy to report all worked fine, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants