-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vulkan-validationlayers: update versions, improve package_type and test_package #21495
base: master
Are you sure you want to change the base?
Conversation
- 1.3.261 does not have vulkan-loaders available for testing. - Loading the validation layer fails in test_package in 1.3.239 for some reason.
Requires vulkan-utility-libraries which has not been merged yet.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…idationlayers # Conflicts: # recipes/vulkan-validationlayers/all/conanfile.py
Conan v1 pipeline ❌Failure in build 2 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
FTR this has served me well while debugging some Vulkan issues under macOS with MoltenVK. Happy to report all worked fine, thanks! |
The package really only exports a
VkLayer_khronos_validation
runtime library and a .json manifest file, especially so after the utility library has been split off intovulkan-utility-libraries
(#21059).I adjusted the
package_type
accordingly toapplication
and updatedtest_package
to test the correct thing.I intended to update the list of versions to match the other recently updated Vulkan and SPIRV packages (meaning only v1.3.239+ SDK versions), but:
vulkan-loader
fortest_package
.spirv-headers
andspirv-tools
.test_package
and I'm not familiar enough with Vulkan to debug it.