-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update recipe for itk/5.3.0 - issue 15104 #23039
Conversation
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @Ruwei thanks a lot for taking the time to add the new version of itk, we appreciate your effort and patience while we got this thru the backlog of PRs. As per #23039 (comment), it seems like at least 1 of the commits is authored by |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I just checked itk cmake files and are looking good, versions 5.2.0 and 5.3.0 differ their macros and included files. I'll investigate Conan 1.x errors. |
I could not reproduce the test package error locally, it's working for this recipe revision and package ID. I just re-triggered the build again. |
This comment has been minimized.
This comment has been minimized.
--------- Co-authored-by: Uilian Ries <[email protected]>
Closing in favour of #25246, where I've kept proper authoring of commits, thanks a lot for your contribution :) |
Conan v1 pipeline ❌Failure in build 47 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
itk/5.3.0
This is a dependency of other libraries I want to package. I'm not the author of itk and have limited knowledge with it.
I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.
The instructions here seem to be wrong and the command "conan config set hooks.conan-center" doesn't work.
I have tried with one configuration locally without the hook activated.