Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry-cpp: Detect cppstd and CXX version #24230

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

steinerthomas
Copy link
Contributor

@steinerthomas steinerthomas commented Jun 5, 2024

Specify library name and version: opentelemetry-cpp/1.14.2

Fixes #24229


@conan-center-bot conan-center-bot added Failed Missing dependencies Build failed due missing dependencies in Conan Center Version conflict There is a version conflict when solving the dependencies graph labels Jun 5, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Jun 5, 2024
@conan-center-bot

This comment has been minimized.

@jcar87 jcar87 self-assigned this Jun 5, 2024
@conan-center-bot

This comment has been minimized.

AbrilRBS
AbrilRBS previously approved these changes Jun 14, 2024
@conan-center-bot conan-center-bot added Missing dependencies Build failed due missing dependencies in Conan Center and removed Version conflict There is a version conflict when solving the dependencies graph labels Jun 14, 2024
@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

We'll probably need to rebuild the missing binary before this can build :)

@conan-center-bot conan-center-bot removed Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Jun 21, 2024
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@toge toge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 15 (bd657ad81cece296bda4e58c3689f228ea9bb20b):

  • opentelemetry-cpp/1.14.2:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.12.0:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.9.1:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.8.3:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 15 (bd657ad81cece296bda4e58c3689f228ea9bb20b):

  • opentelemetry-cpp/1.14.2:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.9.1:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.8.3:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.12.0:
    All packages built successfully! (All logs)

@AbrilRBS
Copy link
Member

AbrilRBS commented Nov 7, 2024

@steinerthomas could you check if the current approach works for you? I've simplified the approach as now we don't have to support Conan 1 anymore

@jcar87
Copy link
Contributor

jcar87 commented Nov 8, 2024

Bear in mind that the original issue is to support Conan 1x #24229
but as of this week it is no longer supported

@AbrilRBS
Copy link
Member

Yay! This finally passes, and I can confirm that it also compiles on Macos. Seeing this, I'll revert some changes to be able to merge the fixes for with_stl=True, thanks again a lot for your patience and taking the time to push this PR to the finish line @steinerthomas, we appreciate it :)

@AbrilRBS
Copy link
Member

@@ -72,6 +71,9 @@ class OpenTelemetryCppConan(ConanFile):

@property
def _min_cppstd(self):
if Version(self.version) < "1.12.0" and self.options.with_stl:
# Old versions require C++17 with STL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steinerthomas
Copy link
Contributor Author

@steinerthomas could you check if the current approach works for you? I've simplified the approach as now we don't have to support Conan 1 anymore

@AbrilRBS looks good to me. I can't test this right now in production, because we still use conan 1. But I hope we can switch to conan 2 soon.

@AbrilRBS AbrilRBS requested review from jcar87 and removed request for toge November 21, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] opentelemetry-cpp/1.14.2: Fails to build with option "with_stl"
6 participants