-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opentelemetry-cpp: Detect cppstd and CXX version #24230
base: master
Are you sure you want to change the base?
opentelemetry-cpp: Detect cppstd and CXX version #24230
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…herwise fix apple-clang build
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
We'll probably need to rebuild the missing binary before this can build :) |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 15 (
Conan v2 pipeline ✔️
All green in build 15 ( |
@steinerthomas could you check if the current approach works for you? I've simplified the approach as now we don't have to support Conan 1 anymore |
Bear in mind that the original issue is to support Conan 1x #24229 |
Yay! This finally passes, and I can confirm that it also compiles on Macos. Seeing this, I'll revert some changes to be able to merge the fixes for |
In fact, seems like we need a newer compiler in case of |
@@ -72,6 +71,9 @@ class OpenTelemetryCppConan(ConanFile): | |||
|
|||
@property | |||
def _min_cppstd(self): | |||
if Version(self.version) < "1.12.0" and self.options.with_stl: | |||
# Old versions require C++17 with STL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to mention, this comes from https://github.com/open-telemetry/opentelemetry-cpp/blob/v1.9.1/CMakeLists.txt#L128
@AbrilRBS looks good to me. I can't test this right now in production, because we still use conan 1. But I hope we can switch to conan 2 soon. |
Specify library name and version: opentelemetry-cpp/1.14.2
Fixes #24229