-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aws refactor] aws-sdk-cpp: Review dependencies, add new version and remove old one #24924
Merged
Merged
Changes from 19 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
b2abbba
[aws refactor] aws-sdk-cpp: Review dependencies, add new version and …
danimtb 1f4a310
patches
danimtb 11d6856
fix
danimtb 71d6063
fix
danimtb 888c2f6
fix
danimtb aa944b6
fix
danimtb b2517aa
Merge branch 'master' into fix/aws13
AbrilRBS faae21f
Merge branch 'master' into fix/aws13
AbrilRBS 436f623
Add patches for new version
AbrilRBS a5ef8cb
Fix missing patch
AbrilRBS 9d22c20
Fix crossbuildings, fix invalid macos invalidation, and dependant fil…
AbrilRBS feeb8fd
Reorder requirements to match upstream dependency declarations
AbrilRBS c43618f
Link Pulseaudio for Android
AbrilRBS e63180c
Add missing requires
AbrilRBS 21de7d0
Cleanup
AbrilRBS fe8414c
Add missing requires
AbrilRBS 0197c45
Fix component requires
AbrilRBS ddd9fd7
Reorder for better checking in new versions in the future
AbrilRBS 90e7f69
Add zlib requirement, else compression fails when it finds it in the …
AbrilRBS 2b5f128
Fix pulseaudio dependency in Android
AbrilRBS c08a148
aws-sdk-cpp: add missing transitive_headers=True
valgur d046db4
Fix pulseaudio for non linux systems
AbrilRBS 8eb8a13
backport pulseaudio to old version
AbrilRBS 1c8b6e7
Add AudioToolbox to text-to-speech frameworks
AbrilRBS e0e616a
Merge branch 'master' into fix/aws13
AbrilRBS cc6b5d6
Validate build issue out
AbrilRBS 1d44a08
Merge branch 'fix/aws13' of github.com:danimtb/conan-center-index int…
AbrilRBS 3d29cd9
Fix
AbrilRBS 141ddd8
Cleanups
AbrilRBS 6b3babd
Merge branch 'fix/aws13' of github.com:danimtb/conan-center-index int…
AbrilRBS 26df3ef
TypO
AbrilRBS 393abf8
Final improvements for aws-sdk-cpp, sdks are now defined per-version
AbrilRBS 512d3ac
Merge branch 'master' into fix/aws13
AbrilRBS c86a614
Merge branch 'master' into fix/aws13
AbrilRBS 306f15f
Back to validate()
AbrilRBS e86aa38
Merge branch 'fix/aws13' of github.com:danimtb/conan-center-index int…
AbrilRBS 664f552
Merge branch 'master' into fix/aws13
AbrilRBS 96483dd
Support Conan 1
AbrilRBS a048d38
Merge branch 'fix/aws13' of github.com:danimtb/conan-center-index int…
AbrilRBS b34f0ff
Back to validate_build()
AbrilRBS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
recipes/aws-sdk-cpp/all/patches/1.11.352-0001-pulseaudio.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
diff --git a/src/aws-cpp-sdk-text-to-speech/CMakeLists.txt b/src/aws-cpp-sdk-text-to-speech/CMakeLists.txt | ||
index 5a40f1906..73a954c3f 100644 | ||
--- a/src/aws-cpp-sdk-text-to-speech/CMakeLists.txt | ||
+++ b/src/aws-cpp-sdk-text-to-speech/CMakeLists.txt | ||
@@ -9,8 +9,6 @@ file( GLOB TEXT_TO_SPEECH_HEADERS "include/aws/text-to-speech/*.h" ) | ||
|
||
set(PLATFORM_LIBS "") | ||
|
||
-check_include_files("pulse/simple.h" HAVE_PULSE) | ||
- | ||
if(PLATFORM_WINDOWS) | ||
file( GLOB TEXT_TO_SPEECH_PLATFORM_HEADERS "include/aws/text-to-speech/windows/*.h" ) | ||
file( GLOB TEXT_TO_SPEECH_PLATFORM_SOURCE "source/text-to-speech/windows/*.cpp" ) | ||
@@ -20,13 +18,14 @@ if(PLATFORM_WINDOWS) | ||
endif() | ||
|
||
if (PLATFORM_LINUX) | ||
- if(HAVE_PULSE) | ||
+ find_package(pulseaudio) | ||
+ if(1) | ||
file( GLOB TEXT_TO_SPEECH_PLATFORM_HEADERS "include/aws/text-to-speech/linux/*.h" ) | ||
file( GLOB TEXT_TO_SPEECH_PLATFORM_SOURCE "source/text-to-speech/linux/*.cpp" ) | ||
|
||
message(STATUS "Pulse audio header files have been detected, included pulse audio as a possible sound driver implementation.") | ||
add_definitions("-DPULSE") | ||
- set(PLATFORM_LIBS ${PLATFORM_LIBS} pulse pulse-simple) | ||
+ set(PLATFORM_LIBS ${PLATFORM_LIBS} "pulseaudio::pulseaudio") | ||
else() | ||
message(WARNING "We've detected that you are building on linux, but the header files for pulseaudio are not available.\ | ||
If you are providing your own audio implementation or you will not be using the text-to-speech library, this is fine.\ |
13 changes: 13 additions & 0 deletions
13
recipes/aws-sdk-cpp/all/patches/1.11.352-0002-disable-sort-links.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
diff --git a/cmake/sdks.cmake b/cmake/sdks.cmake | ||
index 1b1ada7fc..606f5db18 100644 | ||
--- a/cmake/sdks.cmake | ||
+++ b/cmake/sdks.cmake | ||
@@ -271,7 +271,7 @@ function(add_sdks) | ||
|
||
# the catch-all config needs to list all the targets in a dependency-sorted order | ||
include(dependencies) | ||
- sort_links(EXPORTS) | ||
+ #sort_links(EXPORTS) | ||
|
||
# make an everything config by just including all the individual configs | ||
file(WRITE ${CMAKE_BINARY_DIR}/aws-sdk-cpp-config.cmake "") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
versions: | ||
"1.11.352": | ||
folder: "all" | ||
"1.9.234": | ||
folder: "all" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not enable aws-c-sdkutils? I see it is listed here https://github.com/aws/aws-sdk-cpp/blob/1b9f1f48db4bb34967508afcbb91b1a1be992b3c/prefetch_crt_dependency.sh#L17
Also s2n https://github.com/aws/aws-sdk-cpp/blob/1b9f1f48db4bb34967508afcbb91b1a1be992b3c/prefetch_crt_dependency.sh#L20