box2d: add new version 3.0.0 #24946
box2d: add new version 3.0.0 #24946
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@uilianries |
|
@toge I just re-triggered now, thank you for pinging! The previous Conan 2.x build passed, but Conan 1.x was aborted internally by the CI, hope it works now. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Partially reviewed, +3k lines from upstream's diff, is not something easy 😅
I see the project moved to C in this new version: https://c3i.jfrog.io/c3i/misc-v2/logs/pr/24946/5-linux-gcc/box2d/3.0.0//12b14f6c484feae89100caf3d138013fa9682a4d-build.txt
I would suggest removing C++ from the package ID:
def configure(self):
if Version(self.version) >= "3.0.0":
del self.settings.compiler.libcxx
del self.settings.compiler.cppstd
Co-authored-by: Uilian Ries <[email protected]>
| return | ||
|
|
||
| minimum_version = self._compilers_minimum_version.get(str(self.settings.compiler), False) | ||
| if minimum_version and Version(self.settings.compiler.version) < minimum_version: |
There was a problem hiding this comment.
Note that once we drop Conan 1 support, Conan 2 added support for compiler.cstd, which could be useful for C projects like this, see https://docs.conan.io/2/reference/tools/build.html#cstd
Signed-off-by: Uilian Ries <[email protected]>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <[email protected]>
|
Few changes:
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
LGTM. Box2D 3.x has several changes, including moving from C++ to C. More information: https://box2d.org/posts/2023/01/starting-box2d-3.0/
Conan v1 pipeline ✔️All green in build 15 ( |
AbrilRBS
requested review from
uilianries
and removed request for
franramirez688 and
uilianries
|
Big thank you to @toge! 😄 |
Summary
Changes to recipe: box2d/3.0.0
Motivation
box2d/3.0.0 has been completely overhauled.
It is written in C instead of C++.
Details
erincatto/box2d@v2.4.2...v3.0.0