libjpeg: fix build with clang-cl #24951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
1 task
|
@AbrilRBS @uilianries @jcar87 Could you review please? According to #24933 (comment), it fixes the issue. |
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 ( |
jcar87
approved these changes
Oct 2, 2024
AbrilRBS
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: libjpeg/all
Motivation
Fix build of libjpeg with clang-cl (might be a regression coming from #23840)
Details
Use MSBuild branch when we detect a msvc or clang-cl profile (what I call a cl like profile). I don't know if these MSBuild files can work with clang-cl, I'm not sure that replacing NMake by MSBuild in #23840 was a good move.
closes #24933