-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenJPH: Add recipe for new library #25045
OpenJPH: Add recipe for new library #25045
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some comments after a first look :)
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Abril Rincón Blanco <[email protected]>
cfc8f1b
to
7e40578
Compare
This comment has been minimized.
This comment has been minimized.
@AbrilRBS Could you have a look again? Maybe you have an idea for the failure. I looked a while at the failing build and can't make any sense of. The code works with Conan 2 on macOS but not on Conan 1. Otherwise compiler version, C++ standard etc. match so I don't really get what might cause the failure. Also looking at the code it looks fine to me so I'm not having any clue why it fails. |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 11 (
Conan v2 pipeline ✔️
All green in build 11 ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, thanks a lot for taking the time to also add the new version, and sorry about the delay! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM great job! 🐸
Summary
Changes to recipe: openjph/0.15.0
Motivation
I'm currently looking into a multitude of higher-end image compression algorithms and for this I started to look into OpenJPH which isn't yet available through Conan. It is an open source implementation of the High Throughput extension for JPEG 2000. So to try & use it, I created a recipe I want to contribute back.
Details
Adding the library.