Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenJPH: Add recipe for new library #25045

Merged
merged 13 commits into from
Sep 30, 2024

Conversation

irieger
Copy link
Contributor

@irieger irieger commented Aug 25, 2024

Summary

Changes to recipe: openjph/0.15.0

Motivation

I'm currently looking into a multitude of higher-end image compression algorithms and for this I started to look into OpenJPH which isn't yet available through Conan. It is an open source implementation of the High Throughput extension for JPEG 2000. So to try & use it, I created a recipe I want to contribute back.

Details

Adding the library.


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Aug 27, 2024
@conan-center-bot

This comment has been minimized.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some comments after a first look :)

recipes/openjph/all/conanfile.py Outdated Show resolved Hide resolved
recipes/openjph/all/conanfile.py Show resolved Hide resolved
recipes/openjph/all/conanfile.py Show resolved Hide resolved
recipes/openjph/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

1 similar comment
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@irieger
Copy link
Contributor Author

irieger commented Sep 1, 2024

@AbrilRBS Could you have a look again? Maybe you have an idea for the failure.

I looked a while at the failing build and can't make any sense of. The code works with Conan 2 on macOS but not on Conan 1. Otherwise compiler version, C++ standard etc. match so I don't really get what might cause the failure. Also looking at the code it looks fine to me so I'm not having any clue why it fails.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 11 (80daf92ab1f4c21c174ecb5a19db949678c2bc5f):

  • openjph/0.15.0:
    Built 20 packages out of 22 (All logs)

  • openjph/0.16.0:
    Built 20 packages out of 22 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 11 (80daf92ab1f4c21c174ecb5a19db949678c2bc5f):

  • openjph/0.15.0:
    All packages built successfully! (All logs)

  • openjph/0.16.0:
    All packages built successfully! (All logs)

@irieger irieger requested review from jcar87 and AbrilRBS September 19, 2024 10:55
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks a lot for taking the time to also add the new version, and sorry about the delay! :)

@irieger irieger requested a review from SpaceIm September 26, 2024 06:32
Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great job! 🐸

@conan-center-bot conan-center-bot merged commit ac3a327 into conan-io:master Sep 30, 2024
16 checks passed
@irieger irieger deleted the openjph/add-recipe branch September 30, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants