-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eigen: add version cci. 20240315 (pre 3.4.1) #25048
Conversation
This comment has been minimized.
This comment has been minimized.
Use |
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline ✔️
All green in build 3 (
|
LGTM, but why that specific version instead of the latest commit, though? onnxruntime currently uses a much older version altogether: https://gitlab.com/libeigen/eigen/-/commit/e7248b26a1ed53fa030c5c459f7ea095dfd276ac |
This is the latest commit on 3.4 branch: https://gitlab.com/libeigen/eigen/-/tree/3.4?ref_type=heads |
Hi @mayeut thanks a lot for the PR!
You mention that they might release the new patch version in the near future, so I wonder if it's better to wait for an official release/ask upstream to prioritize creating it. Do you have any insight into the timeline for 3.4.1? |
@AbrilRBS, It's been asked a couple times already: The answer is when they have time in the coming months. |
I agree with @mayeut. Besides onnxruntime, I have depended on a pre-release version of Eigen in all CUDA projects that make use of it, since it gets rid of a deluge of irrelevant nvcc warnings that the stable version otherwise produces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussing with @czoido we're moving ahead with this, thanks a lot for the extra info :)
Reverted here as the team reviews how to best proceed #25150
We see risk in making an arbitrary commit available from a pre-release, and exposing it to users who either use version ranges (breaking a promise that it should resolve to release), or users who are force to override because to fix a potential conflict - eigen tends to be backwards compatible, there really isn't a guarantee that things would work, especially for any downstream dependency that uses things un I would try to narrow down exactly which patches of eigen are needed, and we can consider a cci version that is more minimal and minimises risks. Additionally - it would be good to understand the urgency of having onnxruntime 1.19.0 available. |
Summary
Changes to recipe: eigen/all
Motivation
Add a cci specific version in order to be able to build #25039
The 3.4.0 version is 3 years old but unfortunately, there are no tags with all the fixes needed yet.
Details
https://gitlab.com/libeigen/eigen/-/compare/3.4.0...9df21dc8b4b576a7aa5c0094daa8d7e8b8be60f0?from_project_id=15462818&straight=false