Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[level-zero] added new recipe #25068

Merged
merged 4 commits into from
Nov 7, 2024
Merged

[level-zero] added new recipe #25068

merged 4 commits into from
Nov 7, 2024

Conversation

RaguzovaTatyana
Copy link
Contributor

Summary

Changes to recipe: level-zero/1.17.28

Motivation

Openvino recipe needs level-zero to support execution on Intel NPU devices
this library also might be used by libfabric

Details

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@RaguzovaTatyana RaguzovaTatyana force-pushed the level-zero branch 2 times, most recently from ddb5c44 to e504721 Compare September 2, 2024 16:00
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
uilianries
uilianries reviewed Oct 31, 2024
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

recipes/level-zero/all/conanfile.py Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

Sign in to view
uilianries
uilianries reviewed Oct 31, 2024
View reviewed changes
recipes/level-zero/all/conanfile.py Outdated
from conan.errors import ConanInvalidConfiguration
from conan.tools.env import VirtualBuildEnv
from conan.tools.cmake import CMakeToolchain, CMake, cmake_layout, CMakeDeps
from conan.tools.files import get, apply_conandata_patches, copy, export_conandata_patches
Copy link
Member

@uilianries uilianries Oct 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from conan.tools.files import get, apply_conandata_patches, copy, export_conandata_patches
from conan.tools.files import get, apply_conandata_patches, copy, export_conandata_patches, rmdir

One more missing import. The last one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@RaguzovaTatyana RaguzovaTatyana force-pushed the level-zero branch 2 times, most recently from c0f27d3 to 1c40c6d Compare October 31, 2024 11:13
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit 1c40c6d
level-zero/1.17.39@#2f03801bd0294ffb7a82278d74ae003a 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libze_loader.so' links to system library 'dl' but it is not in cpp_info.system_libs.

uilianries
uilianries reviewed Oct 31, 2024
View reviewed changes
recipes/level-zero/all/conanfile.py Outdated
env = VirtualBuildEnv(self)
env.generate()
apply_conandata_patches(self)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
env = VirtualBuildEnv(self)
env.generate()
apply_conandata_patches(self)
apply_conandata_patches(self)

recipes/level-zero/all/test_package/test_package.cpp Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit fa5d5d7
level-zero/1.17.39@#80a053d33412f60663cfe68e87f07ffc 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libze_loader.so' links to system library 'dl' but it is not in cpp_info.system_libs.

uilianries
uilianries reviewed Oct 31, 2024
View reviewed changes
recipes/level-zero/all/conanfile.py Outdated
cmake_layout(self, src_folder="src")

def generate(self):
apply_conandata_patches(self)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
apply_conandata_patches(self)

I guess your last push missed it. Need to move the apply_conandata_patches to build().

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 48 (493ad5bde8cc7fcea6f074005fe95a481c651a16):

  • level-zero/1.17.39:
    Built 8 packages out of 11 (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 48 (493ad5bde8cc7fcea6f074005fe95a481c651a16):

  • level-zero/1.17.39:
    Built 6 packages out of 10 (All logs)

@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit 493ad5b
level-zero/1.17.39@#97c1774d0c3a03d72ac71435cb8bcef7 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libze_loader.so' links to system library 'dl' but it is not in cpp_info.system_libs.

uilianries
uilianries previously approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@uilianries
Copy link
Member

Passed using the infrastructure 🎉

@RaguzovaTatyana
Copy link
Contributor Author

@jcar87 Could you please review?

@jcar87
Copy link
Contributor

jcar87 commented Nov 7, 2024

Sorry - it looks good! I've had a second pass since we now only support Conan 2 and also fixed (or appear to have fixed) the macOS support

@uilianries uilianries merged commit 5ca5224 into conan-io:master Nov 7, 2024
9 checks passed
@uilianries
Copy link
Member

@RaguzovaTatyana your PR has been merged and now Level Zero is available in Conan Center: https://conan.io/center/recipes/level-zero?version=1.17.39. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@culhatsker culhatsker culhatsker left review comments

@uilianries uilianries uilianries approved these changes

@jcar87 jcar87 jcar87 approved these changes

@ilya-lavrenov ilya-lavrenov Awaiting requested review from ilya-lavrenov

Assignees

@jcar87 jcar87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RaguzovaTatyana @conan-center-bot @uilianries @ilya-lavrenov @jcar87 @culhatsker