-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ffmpeg] Re-enable Conan 1.x build #25136
Conversation
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <[email protected]>
Conan 2 paths are shorter by design, so I suppose that's why we're hitting this with Conan 1.x only. The error is actually coming from bash (as invoked by make), not from the linker. There may be a workaround (other than shortening the paths) worth considering: https://github.com/numworks/epsilon/blob/c84216d918d4d822605e6a9b24bb9bbded311014/scripts/toolchain.mingw.mak#L9-L18 - although well, it looks like shell witchcraft ! |
Conan v1 pipeline ❌Failure in build 3 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ✔️
All green in build 4 (
|
Hooks produced the following warnings for commit 062a3bcffmpeg/5.1.3@#2710a311bf9a41c74b1d93663a12300c
ffmpeg/5.0.3@#98812d455c8089bac805c6ce0d32e394
ffmpeg/4.4.4@#f7f3f2bf73b6bef4aae054d330e83955
|
Closing in consideration of #25461 |
Considering the announcement, probably the more reason to ensure that ffmpeg is not broken for Conan 1.x before the freeze :D |
Summary
Changes to recipe: ffmpeg/6.1
Motivation
Similar to PRs #25134 and #25131. The ffmpeg Conan package has a restriction to be built using Conan 1.x on Windows. As the CI received many updates, probably worth checking it.
Details
I can build locally using Conan 1.65.0 + Windows 10 + ffmpeg/6.1.1 + ffmpeg:shared=True:
ffmpeg-6.1.1-msvc-shared.log