mysql-connector-cpp: new recipe #25170

valgur · 2024-09-06T21:40:14Z

Summary

Changes to recipe: mysql-connector-cpp/9.0.0

Motivation

MySQL Connector/C++ is a MySQL database connector for C++. It lets you develop C++ and C applications that connect to MySQL Server.

https://github.com/mysql/mysql-connector-cpp

Details

The project is not doing anything particularly too complex or special in its CMake files overall, but chooses to do some things in quite convoluted and non-standard ways:

boostrap(), which is done by default before project() call. This breaks many Conan variables and targets and does not appear to really be necessary (it's disabled for Ninja, for example).
merge_libraries(). This assumes that all external deps have been built as shared. Static external deps get merged into the final archive file, which leads to "duplicate symbol" linker errors on some compilers, such as apple-clang. I replaced it with the much simpler and more common approach of using OBJECT-type libs for the internal libraries.

Based on

Closes

closes mysqlcpp: add recipe #24678
closes [request] mysql_connector_cpp/8.0.32 #16312
closes [request] mysql-connector-cpp/8.0 #374

Read the contributing guidelines
Checked that this PR is not a duplicate: list of PRs by recipe
Tested locally with at least one configuration using a recent version of Conan

…-cpp' into new/mysql-connector-cpp-2 # Conflicts: # recipes/mysql-connector-cpp/all/conandata.yml # recipes/mysql-connector-cpp/all/conanfile.py # recipes/mysql-connector-cpp/all/test_package/CMakeLists.txt # recipes/mysql-connector-cpp/all/test_package/conanfile.py # recipes/mysql-connector-cpp/config.yml

No longer needed after removing bootstrap().

recipes/mysql-connector-cpp/all/test_package/test_package.cpp

recipes/mysql-connector-cpp/all/conanfile.py

perseoGI

Looking good

Co-authored-by: PerseoGI <[email protected]>

uilianries

Thank you for your PR! This project is one that we tried to package many time, but now, with this PR, we are much closer to achieve it.

I have some concerns about those patches, they are related to the upstream directly, and I don't find any other package manager doing the same. I would suggest opening issues to the upstream reporting about find_dependency and merge_library, otherwise, we will need to keep updating the same patch always.

uilianries · 2024-09-09T10:13:15Z

recipes/mysql-connector-cpp/all/conanfile.py

+        if is_apple_os(self) or self.settings.os in ["Linux", "FreeBSD"]:
+            self.cpp_info.system_libs.extend(["resolv"])
+            if self.settings.os in ["Linux", "FreeBSD"]:
+                self.cpp_info.system_libs.extend(["m", "pthread"])


Suggested change

self.cpp_info.system_libs.extend(["m", "pthread"])

self.cpp_info.system_libs.extend(["m", "pthread", "dl"])

https://github.com/mysql/mysql-connector-cpp/blob/9.0.0/mysql-concpp-config.cmake.in#L463

uilianries · 2024-09-09T10:34:46Z

recipes/mysql-connector-cpp/all/conandata.yml

+    - patch_file: "patches/9.0.0/0001-override-cmake-policy-version.patch"
+      patch_description: "Set CMake policy version to 3.15, move project() statement"
+      patch_type: "conan"


Suggested change

- patch_file: "patches/9.0.0/0001-override-cmake-policy-version.patch"

patch_description: "Set CMake policy version to 3.15, move project() statement"

patch_type: "conan"

I really don't see an error when not using this patch. I would avoid if possible.

Yeah, looks like the issues were caused by bootstrap() rather than the policy version or project() call location.

uilianries · 2024-09-09T10:39:06Z

recipes/mysql-connector-cpp/all/conandata.yml

+    - patch_file: "patches/9.0.0/0001-override-cmake-policy-version.patch"
+      patch_description: "Set CMake policy version to 3.15, move project() statement"
+      patch_type: "conan"
+    - patch_file: "patches/9.0.0/0002-rename-find_dependency.patch"


I would prefer having an issue pointed in the upstream about this. I understand the risk of name collision, but keeping it only here is not good as well.

It's not just a potential risk. The CMake configuration step consistently failed for me due to find_package() calls importing CMakeFindDependencyMacro.

uilianries · 2024-09-09T10:50:57Z

...es/mysql-connector-cpp/all/patches/9.0.0/0006-replace-merge_libraries-with-object-libs.patch

I could not find any other package manager (ubuntu, aur, gentoo and conda) using similar approach. I understand the risk of having duplicated symbols and causing a mess, but this case should be reported to the upstream as well.

Don't be overly reliant on the system-wide package managers as a reference. The issue precisely stems from the upstream project assuming that all of the external libraries are system-wide shared libraries rather than static libs.

It's not just a risk either. The apple-clang compiler refuses to link test_package due to duplicate symbols from OpenSSL and the mysql-connector-cpp lib when OpenSSL is built as static, for example.

I'm not going to reach out to upstream regarding these issues at this time, sorry.

Concerning duplicate symbols and OpenSSL, do you think it's worth trying my approach in the latest commits? In short, remove the OpenSSL dependency from mysqlx and only link it in the foundation target.

In their 'docs' they do explain that an external openssl lib can be included via a new common target.

conan-center-bot · 2024-09-09T13:43:32Z

Conan v1 pipeline ✔️

All green in build 14 (d1e517b5cb7ee06d70890f3d5ccda750fd9c760b):

mysql-connector-cpp/9.0.0:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 14 (d1e517b5cb7ee06d70890f3d5ccda750fd9c760b):

mysql-connector-cpp/9.0.0:
All packages built successfully! (All logs)

husitawi · 2024-09-10T15:12:31Z

Despite that hot mess of CMAKE abstraction files and function, you actually did it, nice finds and well done! 🎉

perseoGI · 2024-09-11T08:45:45Z

@husitawi yes! These are good news!
Lets continue in this one now that is actually passing the CI and try to merge ASAP.

perseoGI · 2024-11-21T10:10:39Z

Would you mind @valgur to add @samuaz with_jdbc option to your recipe?

valgur · 2024-11-21T10:54:23Z

Would you mind @valgur to add @samuaz with_jdbc option to your recipe?

Sure, gladly, but not right now. Maybe after a couple of weeks.

valgur and others added 6 commits December 26, 2023 19:44

mysql-connector-cpp: new recipe

e1b358f

Added mysqlcppconn recipe

daf4bcc

mysql-connector-cpp: fix build

8d61029

mysql-connector-cpp: drop example.cpp

ca62fac

mysql-connector-cpp: fix shared build

3169bfe

conan-center-bot added the Failed label Sep 6, 2024

This comment has been minimized.

Sign in to view

mysql-connector-cpp: use GLOBAL on find_package()

959f42d

This comment has been minimized.

Sign in to view

mysql-connector-cpp: require CMake 3.24+ for GLOBAL

b4a8ed3

This comment has been minimized.

Sign in to view

mysql-connector-cpp: workaound for macOS cross-compilation

11c4023

This comment has been minimized.

Sign in to view

mysql-connector-cpp: another try at macOS cross-compilation

70c612a

This comment has been minimized.

Sign in to view

valgur force-pushed the new/mysql-connector-cpp-2 branch from 1723b98 to f53cac3 Compare September 8, 2024 18:26

mysql-connector-cpp: disable bootstrap() in CMakeLists.txt

f59bd4a

valgur force-pushed the new/mysql-connector-cpp-2 branch from f53cac3 to f59bd4a Compare September 8, 2024 18:28

This comment has been minimized.

Sign in to view

valgur added 2 commits September 8, 2024 22:44

mysql-connector-cpp: replace fragile merge_libraries() with object libs

f8f313e

mysql-connector-cpp: drop target_include_dirs patch

a236350

No longer needed after removing bootstrap().

conan-center-bot removed the Failed label Sep 8, 2024

This comment has been minimized.

Sign in to view

valgur marked this pull request as ready for review September 9, 2024 05:59

valgur mentioned this pull request Sep 9, 2024

mysqlcpp: add recipe #24678

Open

3 tasks

perseoGI reviewed Sep 9, 2024

View reviewed changes

recipes/mysql-connector-cpp/all/test_package/test_package.cpp Show resolved Hide resolved

perseoGI reviewed Sep 9, 2024

View reviewed changes

recipes/mysql-connector-cpp/all/conanfile.py Outdated Show resolved Hide resolved

perseoGI reviewed Sep 9, 2024

View reviewed changes

recipes/mysql-connector-cpp/all/conanfile.py Outdated Show resolved Hide resolved

perseoGI reviewed Sep 9, 2024

View reviewed changes

perseoGI self-assigned this Sep 9, 2024

mysql-connector-cpp: apply review suggestions

2f459ec

Co-authored-by: PerseoGI <[email protected]>

This comment has been minimized.

Sign in to view

uilianries reviewed Sep 9, 2024

View reviewed changes

valgur added 3 commits September 9, 2024 15:45

mysql-connector-cpp: drop override-cmake-policy-version.patch

ed0bb9d

mysql-connector-cpp: add dl to system_libs

3b0ea6b

mysql-connector-cpp: tidy system_libs

d1e517b

valgur force-pushed the new/mysql-connector-cpp-2 branch from 4d3c98c to d1e517b Compare September 9, 2024 12:48

AbrilRBS self-assigned this Sep 12, 2024

AbrilRBS removed their assignment Dec 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mysql-connector-cpp: new recipe #25170

mysql-connector-cpp: new recipe #25170

valgur commented Sep 6, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

perseoGI left a comment

This comment has been minimized.

uilianries left a comment

uilianries Sep 9, 2024

uilianries Sep 9, 2024

valgur Sep 9, 2024

uilianries Sep 9, 2024

valgur Sep 9, 2024

uilianries Sep 9, 2024

valgur Sep 9, 2024 •

edited

Loading

husitawi Sep 11, 2024

conan-center-bot commented Sep 9, 2024

husitawi commented Sep 10, 2024 •

edited

Loading

perseoGI commented Sep 11, 2024

perseoGI commented Nov 21, 2024

valgur commented Nov 21, 2024

	self.cpp_info.system_libs.extend(["m", "pthread"])
	self.cpp_info.system_libs.extend(["m", "pthread", "dl"])

	- patch_file: "patches/9.0.0/0001-override-cmake-policy-version.patch"
	patch_description: "Set CMake policy version to 3.15, move project() statement"
	patch_type: "conan"

mysql-connector-cpp: new recipe #25170

Are you sure you want to change the base?

mysql-connector-cpp: new recipe #25170

Conversation

valgur commented Sep 6, 2024 • edited Loading

Summary

Motivation

Details

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

perseoGI left a comment

Choose a reason for hiding this comment

This comment has been minimized.

uilianries left a comment

Choose a reason for hiding this comment

uilianries Sep 9, 2024

Choose a reason for hiding this comment

uilianries Sep 9, 2024

Choose a reason for hiding this comment

valgur Sep 9, 2024

Choose a reason for hiding this comment

uilianries Sep 9, 2024

Choose a reason for hiding this comment

valgur Sep 9, 2024

Choose a reason for hiding this comment

uilianries Sep 9, 2024

Choose a reason for hiding this comment

valgur Sep 9, 2024 • edited Loading

Choose a reason for hiding this comment

husitawi Sep 11, 2024

Choose a reason for hiding this comment

conan-center-bot commented Sep 9, 2024

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

husitawi commented Sep 10, 2024 • edited Loading

perseoGI commented Sep 11, 2024

perseoGI commented Nov 21, 2024

valgur commented Nov 21, 2024

valgur commented Sep 6, 2024 •

edited

Loading

valgur Sep 9, 2024 •

edited

Loading

husitawi commented Sep 10, 2024 •

edited

Loading