-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade MaterialX to 1.39.1 release #25178
Upgrade MaterialX to 1.39.1 release #25178
Conversation
This comment has been minimized.
This comment has been minimized.
3738bf7
to
326d474
Compare
This comment has been minimized.
This comment has been minimized.
326d474
to
0f077fa
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ❤️
Hi @uilianries, I permit to ping you to have your review :) Thanks @ErniGH . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the new version, I have fixed a few things, otherwise looks good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also disable MATERIALX_BUILD_USE_CCACHE
to be on the safe side for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not easy to review this update:
AcademySoftwareFoundation/MaterialX@v1.38.10...v1.39.1
From main CMakeLists.txt, it looks correct, all new features are deactivated.
Conan v1 pipeline ✔️All green in build 6 (
Conan v2 pipeline ✔️
All green in build 6 ( |
* Upgrade MaterialX to 1.39.1 release * Fix Cmake version and hardcoded cxx standards * Fix Cmake version and hardcoded cxx standards --------- Co-authored-by: Abril Rincón Blanco <[email protected]>
Summary
Add materialx/1.39.1