Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade MaterialX to 1.39.1 release #25178

Merged

Conversation

EstebanDugueperoux2
Copy link
Contributor

Summary

Add materialx/1.39.1

@conan-center-bot conan-center-bot added Bump version PR bumping version without recipe modifications Failed labels Sep 7, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot removed Failed Bump version PR bumping version without recipe modifications labels Sep 8, 2024
@conan-center-bot

This comment has been minimized.

@EstebanDugueperoux2 EstebanDugueperoux2 marked this pull request as ready for review September 8, 2024 09:33
@conan-center-bot

This comment has been minimized.

ErniGH
ErniGH previously approved these changes Sep 10, 2024
Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@EstebanDugueperoux2
Copy link
Contributor Author

Hi @uilianries, I permit to ping you to have your review :)
Thanks in advance.

Thanks @ErniGH .

AbrilRBS
AbrilRBS previously approved these changes Sep 12, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the new version, I have fixed a few things, otherwise looks good :)

@AbrilRBS AbrilRBS requested a review from ErniGH September 12, 2024 11:11
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also disable MATERIALX_BUILD_USE_CCACHE to be on the safe side for now

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not easy to review this update:

AcademySoftwareFoundation/MaterialX@v1.38.10...v1.39.1

Screenshot 2024-09-12 at 16-40-14 Comparing v1 38 10 v1 39 1 · AcademySoftwareFoundation_MaterialX

From main CMakeLists.txt, it looks correct, all new features are deactivated.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 6 (38f67b947c2c5ae0669dfe9b209aef9c59980278):

  • materialx/1.39.1:
    Built 20 packages out of 22 (All logs)

  • materialx/1.38.10:
    Built 20 packages out of 22 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 6 (38f67b947c2c5ae0669dfe9b209aef9c59980278):

  • materialx/1.38.10:
    All packages built successfully! (All logs)

  • materialx/1.39.1:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 78ab0ec into conan-io:master Sep 16, 2024
16 checks passed
OMGtechy pushed a commit to OMGtechy/conan-center-index that referenced this pull request Dec 31, 2024
* Upgrade MaterialX to 1.39.1 release

* Fix Cmake version and hardcoded cxx standards

* Fix Cmake version and hardcoded cxx standards

---------

Co-authored-by: Abril Rincón Blanco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants