Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seq: add recipe #25182

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

seq: add recipe #25182

wants to merge 11 commits into from

Conversation

toge
Copy link
Contributor

@toge toge commented Sep 8, 2024

Summary

Changes to recipe: seq/1.1.0

Motivation

Seq is a stable container library.

Details

https://github.com/Thermadiag/seq/


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Sep 8, 2024

Hooks produced the following warnings for commit 1afd704
seq/1.1.0@#e6174c21e653105d9b7d7d599cdba07d
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './doc/html/structseq_1_1is__relocatable_3_01detail_1_1_store_bucket_3_01_t_00_01_allocator_00_01_value_comp89eb91116fa63e6f37d16c48c57bb022.html' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (e2d4a424b639e6b4b01f0d9a63a000695a4c831d):

  • seq/1.1.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 5 (e2d4a424b639e6b4b01f0d9a63a000695a4c831d):

  • seq/1.1.0:
    All packages built successfully! (All logs)

@AbrilRBS AbrilRBS self-assigned this Nov 11, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some comments, looks good for the most part :)

recipes/seq/all/conanfile.py Outdated Show resolved Hide resolved
recipes/seq/all/conanfile.py Outdated Show resolved Hide resolved
recipes/seq/all/conanfile.py Outdated Show resolved Hide resolved
@toge toge marked this pull request as draft November 12, 2024 08:03
@toge toge marked this pull request as ready for review November 12, 2024 09:56
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recipe looks good, but the CI did not generate packages for header_only=False. Need to check the CI, blocking to avoid merging without the missing configuration.

@AbrilRBS
Copy link
Member

Hi @toge we have a fix ready for this, but we're holding the update for a bit. You don't need to do anything else for this PR, we'll retrigger it once the issue has been fixed on our side, thanks for your patience! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants