-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libarchive: bump deps & use version range for xz_utils & zstd + use correct dependency for with_pcreposix option #25213
libarchive: bump deps & use version range for xz_utils & zstd + use correct dependency for with_pcreposix option #25213
Conversation
This comment has been minimized.
This comment has been minimized.
Reopening this one as it's also a bugfix |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the logs showing that pcre should be used, quite helpful :)
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch with pcre. Indeed that option is False by default, so we didn't see at first review. Thank you.
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline ✔️
All green in build 4 ( |
Summary
Changes to recipe: lib/[version]
Motivation
Use version range for xz_utils & zstd dependencies since it's now allowed, and bump some other deps in the meantime.
While bumping versions, I've realized that pcre2 was duplicated in requirements: with_pcreposix actually requires pcre, not pcre2 (and with_pcre2 requires pcre2), so it's fixed in the meantime.
Details
Proof that
with_pcreposix
(which maps toENABLE_PCREPOSIX
CMake option of upstream CMakeLists) requires pcre, not pcre2:https://github.com/libarchive/libarchive/blob/853bf656ef6d294a4fedc9afc74b262c3c0a6501/CMakeLists.txt#L1306-L1307
https://github.com/libarchive/libarchive/blob/853bf656ef6d294a4fedc9afc74b262c3c0a6501/build/cmake/FindPCREPOSIX.cmake