-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libcurl: add version 8.10.0 #25221
libcurl: add version 8.10.0 #25221
Conversation
This comment has been minimized.
This comment has been minimized.
The curl team modified the root CMakeLists.txt, so this PR will require changes in the recipe. I attached the ones I found. Hopefully they should help to it |
@jmalopoy |
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
replace_in_file(self, cmakelists, "find_package(CARES REQUIRED)", "find_package(c-ares REQUIRED CONFIG)") | ||
replace_in_file(self, cmakelists, "${CARES_LIBRARY}", "c-ares::cares") | ||
if Version(self.version) < "8.10.0": | ||
replace_in_file(self, cmakelists, "find_package(CARES REQUIRED)", "find_package(c-ares REQUIRED CONFIG)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ErniGH, @AbrilRBS
did we consider doing the overrides in the generate() method to avoid this patching?
https://docs.conan.io/2/reference/tools/cmake/cmakedeps.html#overwrite-properties-from-the-consumer-side-using-cmakedeps-set-property
note that we may be able to also set CARES_LIBRARY
via tc.cache_variables
instead of patching the anything
I suspect the same could be done for a lot of the other dependencies
Alternative consider following the pattern of injecting a cmake file during project()
so that we locate and define the relevant variables ahead of time? we could clean this up by A LOT :D
not critical...
* libcurl: add version 8.10.0 * fix cmake compilation errors
Summary
Changes to recipe: libcurl/8.10.0
Motivation
There are several improvements in 8.10.0.
Details
curl/curl@curl-8_9_1...curl-8_10_0