Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcurl: add version 8.10.0 #25221

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Conversation

toge
Copy link
Contributor

@toge toge commented Sep 11, 2024

Summary

Changes to recipe: libcurl/8.10.0

Motivation

There are several improvements in 8.10.0.

Details

curl/curl@curl-8_9_1...curl-8_10_0


@conan-center-bot

This comment has been minimized.

@ErniGH ErniGH self-assigned this Sep 11, 2024
@jmalopoy
Copy link
Contributor

The curl team modified the root CMakeLists.txt, so this PR will require changes in the recipe. I attached the ones I found. Hopefully they should help to it
recipe_8.10.0.patch

@toge
Copy link
Contributor Author

toge commented Sep 12, 2024

@jmalopoy
Thanks you for your advice and contribution.
Sorry. I have little time in this weekend.
Please wait for several days.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (e0352e0551f89b31d7767d687482b1108329e666):

  • libcurl/8.8.0:
    Built 20 packages out of 22 (All logs)

  • libcurl/8.10.0:
    Built 20 packages out of 22 (All logs)

  • libcurl/8.2.1:
    Built 20 packages out of 22 (All logs)

  • libcurl/8.5.0:
    Built 20 packages out of 22 (All logs)

  • libcurl/8.9.1:
    Built 20 packages out of 22 (All logs)

  • libcurl/8.1.2:
    Built 20 packages out of 22 (All logs)

  • libcurl/8.4.0:
    Built 20 packages out of 22 (All logs)

  • libcurl/8.0.1:
    Built 20 packages out of 22 (All logs)

  • libcurl/7.88.1:
    Built 20 packages out of 22 (All logs)

  • libcurl/8.6.0:
    Built 20 packages out of 22 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (e0352e0551f89b31d7767d687482b1108329e666):

  • libcurl/8.0.1:
    All packages built successfully! (All logs)

  • libcurl/8.10.0:
    All packages built successfully! (All logs)

  • libcurl/7.88.1:
    All packages built successfully! (All logs)

  • libcurl/8.6.0:
    All packages built successfully! (All logs)

  • libcurl/8.9.1:
    All packages built successfully! (All logs)

  • libcurl/8.1.2:
    All packages built successfully! (All logs)

  • libcurl/8.8.0:
    All packages built successfully! (All logs)

  • libcurl/8.4.0:
    All packages built successfully! (All logs)

  • libcurl/8.5.0:
    All packages built successfully! (All logs)

  • libcurl/8.2.1:
    All packages built successfully! (All logs)

Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@ErniGH ErniGH requested a review from AbrilRBS September 17, 2024 09:33
@conan-center-bot conan-center-bot merged commit 31d3aa9 into conan-io:master Sep 17, 2024
48 checks passed
replace_in_file(self, cmakelists, "find_package(CARES REQUIRED)", "find_package(c-ares REQUIRED CONFIG)")
replace_in_file(self, cmakelists, "${CARES_LIBRARY}", "c-ares::cares")
if Version(self.version) < "8.10.0":
replace_in_file(self, cmakelists, "find_package(CARES REQUIRED)", "find_package(c-ares REQUIRED CONFIG)")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ErniGH, @AbrilRBS
did we consider doing the overrides in the generate() method to avoid this patching?
https://docs.conan.io/2/reference/tools/cmake/cmakedeps.html#overwrite-properties-from-the-consumer-side-using-cmakedeps-set-property

note that we may be able to also set CARES_LIBRARY via tc.cache_variables instead of patching the anything

I suspect the same could be done for a lot of the other dependencies

Alternative consider following the pattern of injecting a cmake file during project() so that we locate and define the relevant variables ahead of time? we could clean this up by A LOT :D

not critical...

OMGtechy pushed a commit to OMGtechy/conan-center-index that referenced this pull request Dec 31, 2024
* libcurl: add version 8.10.0

* fix cmake compilation errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants