Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed_math: add version 2.0.0, fix install path #25269

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

toge
Copy link
Contributor

@toge toge commented Sep 15, 2024

Summary

Changes to recipe: fixed_math/*

Motivation

Details

arturbac/fixed_math@v1.0.2...v2.0.0


@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

@toge Thank you for your PR 😄 I see it should add the version 2.0.0, but I only see the version 1.0.2 in this PR, is something missing?

@toge
Copy link
Contributor Author

toge commented Sep 16, 2024

@uilianries
Copy link
Member

@toge Sorry, now I see there are 2 folders. Thank you for your quick feedback!

@AbrilRBS AbrilRBS self-assigned this Sep 16, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Successful compilation logs for apple-clang 16:

$ conan create . --version=2.0.0 -b=missing -s=compiler.cppstd=23 -s=compiler.version=16
Migration: Successfully updated settings.yml

======== Exporting recipe to the cache ========
fixed_math/2.0.0: Exporting package recipe: /Users/abril/coding/conan-center-index/recipes/fixed_math/all/conanfile.py
fixed_math/2.0.0: exports: File 'conandata.yml' found. Exporting it...
fixed_math/2.0.0: Copied 1 '.py' file: conanfile.py
fixed_math/2.0.0: Copied 1 '.yml' file: conandata.yml
fixed_math/2.0.0: Exported to cache folder: /Users/abril/.conan2/p/fixed31e86af06d8b1/e
fixed_math/2.0.0: Exported: fixed_math/2.0.0#623ed3f319c4a6e53166796d75baf98b (2024-09-16 15:48:22 UTC)

======== Input profiles ========
Profile host:
[settings]
arch=armv8
build_type=Release
compiler=apple-clang
compiler.cppstd=23
compiler.libcxx=libc++
compiler.version=16
os=Macos
[platform_tool_requires]
cmake/3.29.6
[replace_tool_requires]
meson/*: meson/[>=1.0 <2]
[conf]


Profile build:
[settings]
arch=armv8
build_type=Release
compiler=apple-clang
compiler.cppstd=gnu17
compiler.libcxx=libc++
compiler.version=15
os=Macos
[platform_tool_requires]
cmake/3.29.6
[replace_tool_requires]
meson/*: meson/[>=1.0 <2]
[conf]



======== Computing dependency graph ========
Graph root
    cli
Requirements
    fixed_math/2.0.0#623ed3f319c4a6e53166796d75baf98b - Cache

======== Computing necessary packages ========
fixed_math/2.0.0: Main binary package 'da39a3ee5e6b4b0d3255bfef95601890afd80709' missing
fixed_math/2.0.0: Checking 0 compatible configurations
fixed_math/2.0.0: Compatible configurations not found in cache, checking servers
Requirements
    fixed_math/2.0.0#623ed3f319c4a6e53166796d75baf98b:da39a3ee5e6b4b0d3255bfef95601890afd80709 - Build

======== Installing packages ========
fixed_math/2.0.0: Calling source() in /Users/abril/.conan2/p/fixed31e86af06d8b1/s/src
fixed_math/2.0.0: Unzipping v2.0.0.tar.gz to .

-------- Installing package fixed_math/2.0.0 (1 of 1) --------
fixed_math/2.0.0: Building from source
fixed_math/2.0.0: Package fixed_math/2.0.0:da39a3ee5e6b4b0d3255bfef95601890afd80709
fixed_math/2.0.0: Building your package in /Users/abril/.conan2/p/b/fixed8b9b2a9f357c4/b
fixed_math/2.0.0: Generating aggregated env files
fixed_math/2.0.0: Generated aggregated env files: ['conanbuild.sh', 'conanrun.sh']
fixed_math/2.0.0: Package 'da39a3ee5e6b4b0d3255bfef95601890afd80709' built
fixed_math/2.0.0: Build folder /Users/abril/.conan2/p/b/fixed8b9b2a9f357c4/b/build-release
fixed_math/2.0.0: Generating the package
fixed_math/2.0.0: Packaging in folder /Users/abril/.conan2/p/b/fixed8b9b2a9f357c4/p
fixed_math/2.0.0: Calling package()
fixed_math/2.0.0: package(): Packaged 1 file: LICENCE
fixed_math/2.0.0: package(): Packaged 10 '.h' files
fixed_math/2.0.0: package(): Packaged 1 '.hpp' file: fixed_math.hpp
fixed_math/2.0.0: Created package revision 0005566d694e40d43bc25465c573b4bb
fixed_math/2.0.0: Package 'da39a3ee5e6b4b0d3255bfef95601890afd80709' created
fixed_math/2.0.0: Full package reference: fixed_math/2.0.0#623ed3f319c4a6e53166796d75baf98b:da39a3ee5e6b4b0d3255bfef95601890afd80709#0005566d694e40d43bc25465c573b4bb
fixed_math/2.0.0: Package folder /Users/abril/.conan2/p/b/fixed8b9b2a9f357c4/p

======== Launching test_package ========

======== Computing dependency graph ========
Graph root
    fixed_math/2.0.0 (test package): /Users/abril/coding/conan-center-index/recipes/fixed_math/all/test_package/conanfile.py
Requirements
    fixed_math/2.0.0#623ed3f319c4a6e53166796d75baf98b - Cache

======== Computing necessary packages ========
Requirements
    fixed_math/2.0.0#623ed3f319c4a6e53166796d75baf98b:da39a3ee5e6b4b0d3255bfef95601890afd80709#0005566d694e40d43bc25465c573b4bb - Cache

======== Installing packages ========
fixed_math/2.0.0: Already installed! (1 of 1)

======== Testing the package ========
Removing previously existing 'test_package' build folder: /Users/abril/coding/conan-center-index/recipes/fixed_math/all/test_package/build/apple-clang-16-armv8-23-release
fixed_math/2.0.0 (test package): Test package build: build/apple-clang-16-armv8-23-release
fixed_math/2.0.0 (test package): Test package build folder: /Users/abril/coding/conan-center-index/recipes/fixed_math/all/test_package/build/apple-clang-16-armv8-23-release
fixed_math/2.0.0 (test package): Writing generators to /Users/abril/coding/conan-center-index/recipes/fixed_math/all/test_package/build/apple-clang-16-armv8-23-release/generators
fixed_math/2.0.0 (test package): Generator 'CMakeDeps' calling 'generate()'
fixed_math/2.0.0 (test package): CMakeDeps necessary find_package() and targets for your CMakeLists.txt
    find_package(fixed_math)
    target_link_libraries(... fixed_math::fixed_math)
fixed_math/2.0.0 (test package): Generator 'CMakeToolchain' calling 'generate()'
fixed_math/2.0.0 (test package): CMakeToolchain generated: conan_toolchain.cmake
fixed_math/2.0.0 (test package): CMakeToolchain generated: /Users/abril/coding/conan-center-index/recipes/fixed_math/all/test_package/build/apple-clang-16-armv8-23-release/generators/CMakePresets.json
fixed_math/2.0.0 (test package): CMakeToolchain generated: /Users/abril/coding/conan-center-index/recipes/fixed_math/all/test_package/CMakeUserPresets.json
fixed_math/2.0.0 (test package): Generator 'VirtualRunEnv' calling 'generate()'
fixed_math/2.0.0 (test package): Generating aggregated env files
fixed_math/2.0.0 (test package): Generated aggregated env files: ['conanrun.sh', 'conanbuild.sh']

======== Testing the package: Building ========
fixed_math/2.0.0 (test package): Calling build()
fixed_math/2.0.0 (test package): Running CMake.configure()
fixed_math/2.0.0 (test package): RUN: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/Users/abril/coding/conan-center-index/recipes/fixed_math/all/test_package" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/Users/abril/coding/conan-center-index/recipes/fixed_math/all/test_package"
-- Using Conan toolchain: /Users/abril/coding/conan-center-index/recipes/fixed_math/all/test_package/build/apple-clang-16-armv8-23-release/generators/conan_toolchain.cmake
-- Conan toolchain: Defining libcxx as C++ flags: -stdlib=libc++
-- Conan toolchain: C++ Standard 23 with extensions OFF
-- The CXX compiler identification is AppleClang 16.0.0.16000026
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Users/abril/Downloads/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Conan: Target declared 'fixed_math::fixed_math'
-- Configuring done (5.2s)
-- Generating done (0.0s)
-- Build files have been written to: /Users/abril/coding/conan-center-index/recipes/fixed_math/all/test_package/build/apple-clang-16-armv8-23-release

fixed_math/2.0.0 (test package): Running CMake.build()
fixed_math/2.0.0 (test package): RUN: cmake --build "/Users/abril/coding/conan-center-index/recipes/fixed_math/all/test_package/build/apple-clang-16-armv8-23-release" -- -j12
[ 50%] Building CXX object CMakeFiles/test_package.dir/test_package.cpp.o
[100%] Linking CXX executable test_package
[100%] Built target test_package


======== Testing the package: Executing test ========
fixed_math/2.0.0 (test package): Running test()
fixed_math/2.0.0 (test package): RUN: ./test_package
31.9259 1.0101165771484375

"msvc": "193",
"gcc": "12",
"clang": "15",
"apple-clang": "14",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting compilation errors in apple-clang <=15, seems like apple-clang 16 is needed for this one.

in fact:

$ conan create . --version=2.0.0 -b=missing -s=compiler.cppstd=23 -s=compiler.version=16
Migration: Successfully updated settings.yml

======== Exporting recipe to the cache ========
fixed_math/2.0.0: Exporting package recipe: /Users/abril/coding/conan-center-index/recipes/fixed_math/all/conanfile.py
fixed_math/2.0.0: exports: File 'conandata.yml' found. Exporting it...
fixed_math/2.0.0: Copied 1 '.py' file: conanfile.py
fixed_math/2.0.0: Copied 1 '.yml' file: conandata.yml
fixed_math/2.0.0: Exported to cache folder: /Users/abril/.conan2/p/fixed31e86af06d8b1/e
fixed_math/2.0.0: Exported: fixed_math/2.0.0#623ed3f319c4a6e53166796d75baf98b (2024-09-16 15:48:22 UTC)

======== Input profiles ========
Profile host:
[settings]
arch=armv8
build_type=Release
compiler=apple-clang
compiler.cppstd=23
compiler.libcxx=libc++
compiler.version=16
os=Macos
[platform_tool_requires]
cmake/3.29.6
[replace_tool_requires]
meson/*: meson/[>=1.0 <2]
[conf]


Profile build:
[settings]
arch=armv8
build_type=Release
compiler=apple-clang
compiler.cppstd=gnu17
compiler.libcxx=libc++
compiler.version=15
os=Macos
[platform_tool_requires]
cmake/3.29.6
[replace_tool_requires]
meson/*: meson/[>=1.0 <2]
[conf]



======== Computing dependency graph ========
Graph root
    cli
Requirements
    fixed_math/2.0.0#623ed3f319c4a6e53166796d75baf98b - Cache

======== Computing necessary packages ========
fixed_math/2.0.0: Main binary package 'da39a3ee5e6b4b0d3255bfef95601890afd80709' missing
fixed_math/2.0.0: Checking 0 compatible configurations
fixed_math/2.0.0: Compatible configurations not found in cache, checking servers
Requirements
    fixed_math/2.0.0#623ed3f319c4a6e53166796d75baf98b:da39a3ee5e6b4b0d3255bfef95601890afd80709 - Build

======== Installing packages ========
fixed_math/2.0.0: Calling source() in /Users/abril/.conan2/p/fixed31e86af06d8b1/s/src
fixed_math/2.0.0: Unzipping v2.0.0.tar.gz to .

-------- Installing package fixed_math/2.0.0 (1 of 1) --------
fixed_math/2.0.0: Building from source
fixed_math/2.0.0: Package fixed_math/2.0.0:da39a3ee5e6b4b0d3255bfef95601890afd80709
fixed_math/2.0.0: Building your package in /Users/abril/.conan2/p/b/fixed8b9b2a9f357c4/b
fixed_math/2.0.0: Generating aggregated env files
fixed_math/2.0.0: Generated aggregated env files: ['conanbuild.sh', 'conanrun.sh']
fixed_math/2.0.0: Package 'da39a3ee5e6b4b0d3255bfef95601890afd80709' built
fixed_math/2.0.0: Build folder /Users/abril/.conan2/p/b/fixed8b9b2a9f357c4/b/build-release
fixed_math/2.0.0: Generating the package
fixed_math/2.0.0: Packaging in folder /Users/abril/.conan2/p/b/fixed8b9b2a9f357c4/p
fixed_math/2.0.0: Calling package()
fixed_math/2.0.0: package(): Packaged 1 file: LICENCE
fixed_math/2.0.0: package(): Packaged 10 '.h' files
fixed_math/2.0.0: package(): Packaged 1 '.hpp' file: fixed_math.hpp
fixed_math/2.0.0: Created package revision 0005566d694e40d43bc25465c573b4bb
fixed_math/2.0.0: Package 'da39a3ee5e6b4b0d3255bfef95601890afd80709' created
fixed_math/2.0.0: Full package reference: fixed_math/2.0.0#623ed3f319c4a6e53166796d75baf98b:da39a3ee5e6b4b0d3255bfef95601890afd80709#0005566d694e40d43bc25465c573b4bb
fixed_math/2.0.0: Package folder /Users/abril/.conan2/p/b/fixed8b9b2a9f357c4/p

======== Launching test_package ========

======== Computing dependency graph ========
Graph root
    fixed_math/2.0.0 (test package): /Users/abril/coding/conan-center-index/recipes/fixed_math/all/test_package/conanfile.py
Requirements
    fixed_math/2.0.0#623ed3f319c4a6e53166796d75baf98b - Cache

======== Computing necessary packages ========
Requirements
    fixed_math/2.0.0#623ed3f319c4a6e53166796d75baf98b:da39a3ee5e6b4b0d3255bfef95601890afd80709#0005566d694e40d43bc25465c573b4bb - Cache

======== Installing packages ========
fixed_math/2.0.0: Already installed! (1 of 1)

======== Testing the package ========
Removing previously existing 'test_package' build folder: /Users/abril/coding/conan-center-index/recipes/fixed_math/all/test_package/build/apple-clang-16-armv8-23-release
fixed_math/2.0.0 (test package): Test package build: build/apple-clang-16-armv8-23-release
fixed_math/2.0.0 (test package): Test package build folder: /Users/abril/coding/conan-center-index/recipes/fixed_math/all/test_package/build/apple-clang-16-armv8-23-release
fixed_math/2.0.0 (test package): Writing generators to /Users/abril/coding/conan-center-index/recipes/fixed_math/all/test_package/build/apple-clang-16-armv8-23-release/generators
fixed_math/2.0.0 (test package): Generator 'CMakeDeps' calling 'generate()'
fixed_math/2.0.0 (test package): CMakeDeps necessary find_package() and targets for your CMakeLists.txt
    find_package(fixed_math)
    target_link_libraries(... fixed_math::fixed_math)
fixed_math/2.0.0 (test package): Generator 'CMakeToolchain' calling 'generate()'
fixed_math/2.0.0 (test package): CMakeToolchain generated: conan_toolchain.cmake
fixed_math/2.0.0 (test package): CMakeToolchain generated: /Users/abril/coding/conan-center-index/recipes/fixed_math/all/test_package/build/apple-clang-16-armv8-23-release/generators/CMakePresets.json
fixed_math/2.0.0 (test package): CMakeToolchain generated: /Users/abril/coding/conan-center-index/recipes/fixed_math/all/test_package/CMakeUserPresets.json
fixed_math/2.0.0 (test package): Generator 'VirtualRunEnv' calling 'generate()'
fixed_math/2.0.0 (test package): Generating aggregated env files
fixed_math/2.0.0 (test package): Generated aggregated env files: ['conanrun.sh', 'conanbuild.sh']

======== Testing the package: Building ========
fixed_math/2.0.0 (test package): Calling build()
fixed_math/2.0.0 (test package): Running CMake.configure()
fixed_math/2.0.0 (test package): RUN: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/Users/abril/coding/conan-center-index/recipes/fixed_math/all/test_package" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/Users/abril/coding/conan-center-index/recipes/fixed_math/all/test_package"
-- Using Conan toolchain: /Users/abril/coding/conan-center-index/recipes/fixed_math/all/test_package/build/apple-clang-16-armv8-23-release/generators/conan_toolchain.cmake
-- Conan toolchain: Defining libcxx as C++ flags: -stdlib=libc++
-- Conan toolchain: C++ Standard 23 with extensions OFF
-- The CXX compiler identification is AppleClang 16.0.0.16000026
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Users/abril/Downloads/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Conan: Target declared 'fixed_math::fixed_math'
-- Configuring done (5.2s)
-- Generating done (0.0s)
-- Build files have been written to: /Users/abril/coding/conan-center-index/recipes/fixed_math/all/test_package/build/apple-clang-16-armv8-23-release

fixed_math/2.0.0 (test package): Running CMake.build()
fixed_math/2.0.0 (test package): RUN: cmake --build "/Users/abril/coding/conan-center-index/recipes/fixed_math/all/test_package/build/apple-clang-16-armv8-23-release" -- -j12
[ 50%] Building CXX object CMakeFiles/test_package.dir/test_package.cpp.o
[100%] Linking CXX executable test_package
[100%] Built target test_package


======== Testing the package: Executing test ========
fixed_math/2.0.0 (test package): Running test()
fixed_math/2.0.0 (test package): RUN: ./test_package
31.9259 1.0101165771484375

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (1bfaaa6e5a5b74dde5210e1203f4f8428ffcaf29):

  • fixed_math/1.0.2:
    Built 18 packages out of 27 (All logs)

  • fixed_math/2.0.0:
    No packages built ⚠️ (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (1bfaaa6e5a5b74dde5210e1203f4f8428ffcaf29):

  • fixed_math/1.0.2:
    Built 12 packages out of 14 (All logs)

  • fixed_math/2.0.0:
    No packages built ⚠️ (All logs)

@toge
Copy link
Contributor Author

toge commented Sep 19, 2024

@AbrilRBS
Thank you for your improvement!

@AbrilRBS AbrilRBS requested a review from danimtb September 19, 2024 08:40
@conan-center-bot conan-center-bot merged commit f909134 into conan-io:master Sep 20, 2024
16 checks passed
OMGtechy pushed a commit to OMGtechy/conan-center-index that referenced this pull request Dec 31, 2024
* fixed_math: add version 2.0.0

* fix trailing spaces

* fix install path

* Update recipes/fixed_math/all/conanfile.py

---------

Co-authored-by: Abril Rincón Blanco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants