Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new recipe ann/1.1.2 #25273

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Sep 15, 2024

Summary

Changes to recipe: ann/1.1.2

Motivation

Add ANN library to conancenter.

Details

  • Upstream there are some raw Makefiles and a vcproj file (only for DLL, not static). I've written a simple CMakeLists instead (library is very simple to compile), so that it can be more portable.
  • A small fix is needed for static lib on windows in order to avoid dllexport/dllimport. So a ANN_STATIC definition is introduced, it must be defined at build & consume time if windows & static.
  • Another fix is needed for compilation with C++17 or above: there are register keyword in front of several variables in source code (several cpp files & private headers, no fix required in public headers). It's useless and not supported at all since C++17.
  • The latest version is from 2010, so I don't hope any backport of these patches upstream.

Closes #25263


@SpaceIm
Copy link
Contributor Author

SpaceIm commented Sep 15, 2024

FYI, it's an optional dependency of Graphviz (it's required by libmingle component of Graphviz).

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit b4ffc83
ann/1.1.2@#08fcc2924283cc35c7d588215f0d5fff
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libANN.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (f3a2ed7006c5f1124488e57ed4782605dc902524):

  • ann/1.1.2:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (f3a2ed7006c5f1124488e57ed4782605dc902524):

  • ann/1.1.2:
    All packages built successfully! (All logs)

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@AbrilRBS AbrilRBS self-assigned this Sep 16, 2024
@conan-center-bot conan-center-bot merged commit 81168ea into conan-io:master Sep 18, 2024
12 checks passed
@SpaceIm SpaceIm deleted the new/ann/1.1.2 branch September 18, 2024 18:31
OMGtechy pushed a commit to OMGtechy/conan-center-index that referenced this pull request Dec 31, 2024
* add ann/1.1.2

* add libm to system libs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] ann/1.1.2
4 participants