Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mathter: add new version 2.0.0 #25307

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

petiaccja
Copy link
Contributor

@petiaccja petiaccja commented Sep 18, 2024

Summary

Changes to recipe: mathter/2.0.0

Motivation

Publishing a new version of this library on conan so that it's more accessible to users.

Details

  • Moved previous versions (previously all folder) to the 1.x.x folder
  • Version 2.0.0 and on (now the all folder) has a different method for packaging:
    • The library stayed header-only, but...
    • The library was updated to support CMake's --install option to install the headers
    • The conanfile.py now uses the CMake install procedure, like for a compiled a library
    • The CMake installation is tested on the library's own CI and its logic is not duplicated in the conanfile.py

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@petiaccja petiaccja marked this pull request as ready for review September 19, 2024 10:40
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (d12c2b2065fab705152f61e4689906683317fe38):

  • mathter/1.1.1:
    Built 5 packages out of 11 (All logs)

  • mathter/1.1.0:
    Built 5 packages out of 11 (All logs)

  • mathter/1.0.0:
    Built 5 packages out of 11 (All logs)

  • mathter/2.0.0:
    Built 5 packages out of 11 (All logs)

  • mathter/1.0.1:
    Built 5 packages out of 11 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 5 (d12c2b2065fab705152f61e4689906683317fe38):

  • mathter/1.1.1:
    Built 2 packages out of 5 (All logs)

  • mathter/1.1.0:
    Built 2 packages out of 5 (All logs)

  • mathter/1.0.1:
    Built 4 packages out of 5 (All logs)

  • mathter/1.0.0:
    Built 4 packages out of 5 (All logs)

  • mathter/2.0.0:
    Built 4 packages out of 5 (All logs)

@AbrilRBS AbrilRBS self-assigned this Sep 25, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot for taking the time to update the recipe, we appreciate it :)

@AbrilRBS AbrilRBS requested a review from ErniGH September 25, 2024 11:33
Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 😄

@conan-center-bot conan-center-bot merged commit c1a43e1 into conan-io:master Oct 1, 2024
28 checks passed
@petiaccja
Copy link
Contributor Author

Thanks for the review folks!

@petiaccja petiaccja deleted the mathter-v2.0.0 branch October 1, 2024 15:33
@AbrilRBS AbrilRBS mentioned this pull request Oct 2, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants