Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openvino/2024.4.0 update #25327

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

culhatsker
Copy link
Contributor

Summary

Changes to recipe: openvino/2024.4.0

Motivation

New release

Details

No specific details, only added new package links and sha256 hashes


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since OpenVINO 2024.4, static build of CPU and GPU plugin can be combined together.

So, could you please add a version check here

if self.options.get_safe("enable_gpu") and not self.options.shared and self.options.enable_cpu:
# GPU and CPU plugins cannot be simultaneously built statically, because they use different oneDNN versions
self.output.warning(f"{self.name} recipe builds GPU plugin without oneDNN (dGPU) support during static build, "
"because CPU plugin compiled with different oneDNN version may cause ODR violation. "
"To enable oneDNN support for GPU plugin, please, either use shared build configuration "
"or disable CPU plugin by setting 'enable_cpu' option to False.")
?

@conan-center-bot

This comment has been minimized.

@ErniGH ErniGH self-assigned this Sep 20, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (f1572bb9a9d8445dc4ed87b72623632ea169c749):

  • openvino/2024.4.0:
    Built 10 packages out of 22 (All logs)

  • openvino/2024.3.0:
    Built 12 packages out of 22 (All logs)

  • openvino/2024.2.0:
    Built 12 packages out of 22 (All logs)

  • openvino/2024.0.0:
    Built 12 packages out of 22 (All logs)

  • openvino/2023.2.0:
    Built 12 packages out of 22 (All logs)

  • openvino/2024.1.0:
    Built 12 packages out of 22 (All logs)

  • openvino/2023.3.0:
    Built 12 packages out of 22 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (f1572bb9a9d8445dc4ed87b72623632ea169c749):

  • openvino/2024.2.0:
    All packages built successfully! (All logs)

  • openvino/2024.0.0:
    All packages built successfully! (All logs)

  • openvino/2024.3.0:
    All packages built successfully! (All logs)

  • openvino/2024.4.0:
    All packages built successfully! (All logs)

  • openvino/2024.1.0:
    All packages built successfully! (All logs)

  • openvino/2023.3.0:
    All packages built successfully! (All logs)

  • openvino/2023.2.0:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

No further change found on build side between 2024.4 and 2024.3: openvinotoolkit/openvino@2024.3.0...2024.4.0#diff-a569c4555e0eefde7ad22cdb2329257461f5f6d483b717e7f7f50d55ecbf0734

The Onednn_gpu has no build changes since last version in CCI: oneapi-src/oneDNN@7ab8ee9...4ccd07e

The Onednn_cpu has changes, but in specific this one follows the current change in the recipe: openvinotoolkit/openvino@2024.3.0...2024.4.0#diff-a569c4555e0eefde7ad22cdb2329257461f5f6d483b717e7f7f50d55ecbf0734

@ilya-lavrenov
Copy link
Contributor

LGTM.

No further change found on build side between 2024.4 and 2024.3: openvinotoolkit/[email protected]#diff-a569c4555e0eefde7ad22cdb2329257461f5f6d483b717e7f7f50d55ecbf0734

The Onednn_gpu has no build changes since last version in CCI: oneapi-src/[email protected]

The Onednn_cpu has changes, but in specific this one follows the current change in the recipe: openvinotoolkit/[email protected]#diff-a569c4555e0eefde7ad22cdb2329257461f5f6d483b717e7f7f50d55ecbf0734

openvinotoolkit/openvino#25962

@uilianries
Copy link
Member

@ilya-lavrenov Thank you for the reference! 😄

@AbrilRBS AbrilRBS self-assigned this Sep 23, 2024
Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@conan-center-bot conan-center-bot merged commit 1daf9a8 into conan-io:master Sep 24, 2024
33 checks passed
@culhatsker culhatsker deleted the openvino/2024.4.0 branch September 24, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants