-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openblas: add v0.3.28, drop old versions and patches, add OpenMP and ILP64 support #25344
Open
valgur
wants to merge
14
commits into
conan-io:master
Choose a base branch
from
valgur:update/openblas
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+191
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cc @samuel-emrys since you seem to be interested in BLAS and LAPACK support on CCI. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 4 ( |
This was referenced Sep 24, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: openblas/[*]
Motivation
The current recipe is missing options for a few core features like OpenMP, ILP64 and the max number of available threads.
This limits its usefulness in libraries that significantly relies on BLAS for linear algebra performance.
Details
Adds latest v0.3.28 and drops all versions v0.3.20 and older, which gets rid of many patches and checks.
Also adds support for all major options in the build system: https://github.com/OpenMathLib/OpenBLAS/blob/develop/docs/build_system.md#important-variables
Fixed the exporting of serial/pthread/openmp component.
The value of 128 for the max number of threads was picked based on the value used by Debian and the current upper limit of available cores on consumer-grade hardware. Spack uses a value of 512, for example, but they also mostly target supercomputers.