Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/qt packages not used in requires #5997

Conversation

CAMOBAP
Copy link
Contributor

@CAMOBAP CAMOBAP commented Jun 20, 2021

qt/5.15.2

Related issue #5931


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@CAMOBAP CAMOBAP force-pushed the bugfix/qt-packages-not-used-in-requires branch from 88b5225 to 7e37ded Compare June 20, 2021 18:18
@ghost
Copy link

ghost commented Jun 20, 2021

I detected other pull requests that are modifying qt/5.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@prince-chrismc
Copy link
Contributor

A conflicting PR was merged with parts of the same fixes

@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Jun 21, 2021

@prince-chrismc yep, I will update my PR because it include handling of alsa and glib too

UPD. PR was updated

@CAMOBAP CAMOBAP force-pushed the bugfix/qt-packages-not-used-in-requires branch from 7e37ded to 047333b Compare June 21, 2021 14:20
@SpaceIm
Copy link
Contributor

SpaceIm commented Jun 21, 2021

FYI, I'm working on a big fix in package_info() of qt6:

  • add missing dependencies in requires (glib, zstd, vulkan-loader)
  • add missing plugins and modules (too many to list them here 😄 )
  • add modules/plugins only when proper options are set (it can be very complex) or dependencies missing.
  • fix few internal dependencies in modules
  • add a lot of system libs and frameworks in several modules and plugins
  • unvendor few libs (libtiff and libwebp for qtimageformats)

@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Jun 21, 2021

@SpaceIm oh, thanks for sharing this, will it backported to qt5? I mean should I keep this PR or close it because of the upcoming one?

@SpaceIm
Copy link
Contributor

SpaceIm commented Jun 21, 2021

Keep it, I do not plan to work on qt5 recipe soon.

@conan-center-bot

This comment has been minimized.

@prince-chrismc
Copy link
Contributor

AssertionError: PREV for opengl/system:5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9 is None

CI bug...

You'll need to retrigger CI, close the pr wait 10s and then re-open it 🔁

@CAMOBAP CAMOBAP closed this Jun 22, 2021
@CAMOBAP CAMOBAP reopened this Jun 22, 2021
@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request Jun 22, 2021
4 tasks
@ericLemanissier
Copy link
Contributor

@CAMOBAP you can retrigger CI, this kind of failure should go away.

@CAMOBAP CAMOBAP closed this Jun 24, 2021
@CAMOBAP CAMOBAP reopened this Jun 24, 2021
@conan-center-bot
Copy link
Collaborator

All green in build 6 (047333bdad5caa957d457e7ce59d760de3a77c70):

  • qt/5.15.2@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 0f7bb46 into conan-io:master Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants